Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1468823002: Subzero: Add a makefile config for building with g++. (Closed)

Created:
5 years, 1 month ago by Jim Stichnoth
Modified:
5 years, 1 month ago
Reviewers:
Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Add a makefile config for building with g++. This way, the g++ build for the "make presubmit" target gets a separate build directory, and gets to use ccache. Also, get rid of the "git diff" test, because uncommitted changes are already checked by "git cl upload" and "git cl land". BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=fc22f770aba94a485d27acbf1a5acc73487f9e54

Patch Set 1 #

Patch Set 2 : Remove the "git diff" check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M Makefile.standalone View 1 3 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
5 years, 1 month ago (2015-11-22 06:16:52 UTC) #3
John
lgtm
5 years, 1 month ago (2015-11-22 14:02:51 UTC) #5
Jim Stichnoth
5 years, 1 month ago (2015-11-22 14:06:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fc22f770aba94a485d27acbf1a5acc73487f9e54 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698