Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1468803002: Switch to static_assert. (Closed)

Created:
5 years, 1 month ago by Avi (use Gerrit)
Modified:
5 years ago
CC:
chromium-reviews, qsr+mojo_chromium.org, zea+watch_chromium.org, vmpstr+watch_chromium.org, posciak+watch_chromium.org, yzshen+watch_chromium.org, ben+mojo_chromium.org, miu+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, grt+watch_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, chromium-apps-reviews_chromium.org, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, wfh+watch_chromium.org, maxbogue+watch_chromium.org, mcasas+watch_chromium.org, Aaron Boodman, plaree+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@assert1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to static_assert in the repo. BUG=442514 Committed: https://crrev.com/0cc1cac60fa31330162cb8ec68ec2b0eabe3631b Cr-Commit-Position: refs/heads/master@{#361408}

Patch Set 1 #

Patch Set 2 : moar green #

Patch Set 3 : moar moar moar #

Patch Set 4 : close #

Patch Set 5 : just about there #

Patch Set 6 : win #

Total comments: 1

Patch Set 7 : message cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -200 lines) Patch
M chrome/browser/extensions/window_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 2 3 4 5 6 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/installer/util/channel_info.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/delete_tree_work_item.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/google_update_settings_unittest.cc View 1 2 3 4 5 6 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/installer/util/install_util.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/installation_state.cc View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/installer/util/installer_state.cc View 1 2 3 4 5 6 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/installer/util/logging_installer.h View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/util_constants.h View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M components/font_service/font_service_app.cc View 1 2 3 4 5 6 1 chunk +12 lines, -13 lines 0 comments Download
M components/html_viewer/blink_basic_type_converters.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M components/html_viewer/blink_text_input_type_converters.cc View 1 2 3 4 5 6 2 chunks +8 lines, -8 lines 0 comments Download
M components/html_viewer/html_frame_properties.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M components/html_viewer/web_socket_handle_impl.cc View 1 2 3 4 5 6 1 chunk +7 lines, -8 lines 0 comments Download
M components/mus/public/cpp/window_property.h View 1 2 3 4 5 6 1 chunk +4 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/login_database.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/password_manager/core/browser/login_database_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/background_sync/background_sync_service_impl.cc View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_sync_writer_unittest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/background_sync/background_sync_type_converters.cc View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc/stun_field_trial.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_websocket_host.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/id_allocator.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/navigation/crw_session_certificate_policy_manager.mm View 1 2 3 4 5 6 1 chunk +26 lines, -26 lines 0 comments Download
M media/audio/audio_parameters.h View 1 2 3 4 5 6 2 chunks +6 lines, -5 lines 0 comments Download
M media/base/yuv_convert.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/ime/ime_type_converters.cc View 1 2 3 4 5 6 2 chunks +8 lines, -8 lines 0 comments Download
M mojo/converters/input_events/input_events_type_converters.cc View 1 2 3 4 5 6 1 chunk +39 lines, -40 lines 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.cc View 1 2 3 4 5 6 2 chunks +8 lines, -8 lines 0 comments Download
M mojo/environment/default_logger_impl.cc View 1 2 3 4 5 6 1 chunk +10 lines, -10 lines 0 comments Download
M mojo/services/network/web_socket_impl.cc View 1 2 3 4 5 6 1 chunk +9 lines, -9 lines 0 comments Download
M sandbox/linux/services/namespace_utils.h View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M third_party/libaddressinput/chromium/override/basictypes_override.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/message_center/views/notification_view_unittest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 39 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468803002/1
5 years, 1 month ago (2015-11-22 02:04:59 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-generic_chromium_compile_only_ng/builds/60585)
5 years, 1 month ago (2015-11-22 02:23:09 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468803002/20001
5 years, 1 month ago (2015-11-22 02:27:56 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468803002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468803002/40001
5 years, 1 month ago (2015-11-22 02:39:54 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/144505)
5 years, 1 month ago (2015-11-22 03:15:57 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468803002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468803002/60001
5 years, 1 month ago (2015-11-22 03:28:30 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/123997)
5 years, 1 month ago (2015-11-22 03:59:29 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468803002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468803002/80001
5 years, 1 month ago (2015-11-22 04:28:01 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/112053)
5 years, 1 month ago (2015-11-22 05:43:36 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468803002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468803002/100001
5 years, 1 month ago (2015-11-22 15:27:01 UTC) #20
Avi (use Gerrit)
One, because you OWN it all, and two, mojo is the one thing I'm slightly ...
5 years, 1 month ago (2015-11-22 17:18:27 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-22 20:16:56 UTC) #24
Ben Goodger (Google)
lgtm
5 years, 1 month ago (2015-11-22 22:07:44 UTC) #25
Mostyn Bramley-Moore
FYI- I previously had trouble with the chrome installer breaking somewhere outside the main/CQ builds, ...
5 years, 1 month ago (2015-11-23 06:50:10 UTC) #26
Nico
https://codereview.chromium.org/1468803002/diff/100001/base/macros.h File base/macros.h (left): https://codereview.chromium.org/1468803002/diff/100001/base/macros.h#oldcode74 base/macros.h:74: #define COMPILE_ASSERT(expr, msg) static_assert(expr, #msg) (maybe land the change ...
5 years ago (2015-11-24 14:45:02 UTC) #28
Avi (use Gerrit)
On 2015/11/23 06:50:10, Mostyn Bramley-Moore wrote: > FYI- I previously had trouble with the chrome ...
5 years ago (2015-11-24 16:07:01 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468803002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468803002/120001
5 years ago (2015-11-24 16:11:34 UTC) #32
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-24 18:59:33 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468803002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468803002/120001
5 years ago (2015-11-24 19:04:23 UTC) #37
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years ago (2015-11-24 19:12:21 UTC) #38
commit-bot: I haz the power
5 years ago (2015-11-24 19:13:29 UTC) #39
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/0cc1cac60fa31330162cb8ec68ec2b0eabe3631b
Cr-Commit-Position: refs/heads/master@{#361408}

Powered by Google App Engine
This is Rietveld 408576698