Issue 14688012: Turn off Clang virtual/OVERRIDE warnings in .cc files when use_aura==1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14688012: Turn off Clang virtual/OVERRIDE warnings in .cc files when use_aura==1 (Closed)

Created:
7 years, 7 months ago by Ryan Sleevi

Modified:
7 years, 7 months ago

Reviewers:
Nico, (unused - use chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Turn off Clang virtual/OVERRIDE warnings in .cc files when use_aura==1 r197789 enabled the Clang warnings for Linux, but Aura-only files weren't fixed because it wasn't enabled for ChromeOS. Disable the warnings on Aura for now, until all existing files can be fixed. BUG=115047 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197944

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

7 years, 7 months ago (2013-05-02 18:20:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r197944 (presubmit successful).

Expand Messages | Collapse Messages