Reland of Remove blink::WebLayerClient and WebGraphicsLayerDebugInfo.

Reland of Remove blink::WebLayerClient and WebGraphicsLayerDebugInfo.

It is now legal for Blink to provide an implementation of cc::LayerClient.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=danakj@chromium.org

Committed: https://crrev.com/60b29f0509636a9c6b34cc770a0347d46422f5a7
Cr-Commit-Position: refs/heads/master@{#361195}

[jbroman, 2015-11-21 05:39:31]

Description was changed from

==========
Reland of Remove blink::WebLayerClient and WebGraphicsLayerDebugInfo.

It is now legal for Blink to provide an implementation of cc::LayerClient.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Reland of Remove blink::WebLayerClient and WebGraphicsLayerDebugInfo.

It is now legal for Blink to provide an implementation of cc::LayerClient.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jbroman, 2015-11-21 05:39:31]

jbroman@chromium.org changed reviewers:
+ chrishtr@chromium.org, danakj@chromium.org, enne@chromium.org,
esprehn@chromium.org

[jbroman, 2015-11-21 05:47:07]

The original CL (https://codereview.chromium.org/1419913002) was reverted due to
problems in context_lost_tests (on debug builds).

The root problem is that this causes GraphicsLayer::m_contentsLayer to be
destroyed (but a dangling pointer remains in GraphicsLayer), and so a crash
occurs when we try to get its cc::Layer to compare with the one we were asked to
describe.

The simplest solution is to use the existing m_contentsLayerId instead to
identify that layer. The diff between patch 1 (the original patch, merged with
origin/master) and patch 2 (the fixed patch, verified locally) shows this simple
change. It also adds an include of cc/layers/layer.h to GraphicsLayer.cpp, in
order to access the ID of the provided cc layer.

(enne in particular, can you confirm that this is a reasonable fix?)

[chrishtr, 2015-11-21 23:33:54]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-11-21 23:33:54]

lgtm

[commit-bot: I haz the power, 2015-11-21 23:34:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1468753002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1468753002/20001

[commit-bot: I haz the power, 2015-11-21 23:41:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-21 23:41:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[enne (OOO), 2015-11-23 18:54:58]

lgtm

[jbroman, 2015-11-23 19:05:08]

Description was changed from

==========
Reland of Remove blink::WebLayerClient and WebGraphicsLayerDebugInfo.

It is now legal for Blink to provide an implementation of cc::LayerClient.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Reland of Remove blink::WebLayerClient and WebGraphicsLayerDebugInfo.

It is now legal for Blink to provide an implementation of cc::LayerClient.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=danakj@chromium.org
==========

[jbroman, 2015-11-23 19:05:53]

TBRing danakj for remaining ownership (ui/compositor/, dependency on base/),
since those parts are unchanged since the original CL

[jbroman, 2015-11-23 19:05:54]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2015-11-23 19:07:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1468753002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1468753002/20001

[danakj, 2015-11-23 19:36:11]

On 2015/11/23 19:05:53, jbroman wrote:
> TBRing danakj for remaining ownership (ui/compositor/, dependency on base/),
> since those parts are unchanged since the original CL

rs lgtm

[commit-bot: I haz the power, 2015-11-23 21:51:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-23 21:52:59]

Patchset 2 (id:??) landed as
https://crrev.com/60b29f0509636a9c6b34cc770a0347d46422f5a7
Cr-Commit-Position: refs/heads/master@{#361195}