DevTools: Prettify websocket frames preview on Network pane.

third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

 /*
  * Copyright (C) 2012 Research In Motion Limited. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 100 matching lines @@
         var frame = /** @type {!WebInspector.NetworkRequest.WebSocketFrame} */ (event.data);
         this._dataGrid.insertChild(new WebInspector.ResourceWebSocketFrameNode(frame));
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _onFrameSelected: function(event)
     {
         var selectedNode = /** @type {!WebInspector.ResourceWebSocketFrameNode} */ (event.target.selectedNode);
-        if (this._messageView)
-            this._messageView.detach();
-        if (this._dataView)
-            this._dataView.detach();
-        this._dataView = new WebInspector.ResourceSourceFrame(selectedNode.contentProvider());
-        this._splitWidget.setSidebarWidget(this._dataView);
+        var contentProvider = selectedNode.contentProvider();

[caseq, 2015/11/20 22:23:41]

nit: drop the var?

[alph, 2015/11/20 22:38:46]

noway

+        contentProvider.requestContent(contentReady.bind(this));
+        /**
+         * @this {WebInspector.ResourceWebSocketFrameView}

[caseq, 2015/11/20 22:23:41]

nit: @param, then @this?

[alph, 2015/11/20 22:38:46]

Done.

+         * @param {?string} content
+         */
+        function contentReady(content)
+        {
+            if (this._messageView)

[caseq, 2015/11/20 22:23:41]

s/this._messageView/this._currentView/ and nuke the this._dataView, then remove
conditional here.

[alph, 2015/11/20 22:38:46]

I can go deeper.

+                this._messageView.detach();
+            if (this._dataView)
+                this._dataView.detach();
+            var parsedJSON = content ? WebInspector.JSONView.parseJSON(content) : null;
+            this._dataView = parsedJSON ? new WebInspector.JSONView(parsedJSON) : new WebInspector.ResourceSourceFrame(contentProvider);
+            this._splitWidget.setSidebarWidget(this._dataView);
+        }
     },
 
     refresh: function()
     {
         this._dataGrid.rootNode().removeChildren();
         var frames = this._request.frames();
         for (var i = 0; i < frames.length; ++i)
             this._dataGrid.insertChild(new WebInspector.ResourceWebSocketFrameNode(frames[i]));
     },
 
@@ skipping 80 matching lines @@
 
 /**
  * @param {!WebInspector.ResourceWebSocketFrameNode} a
  * @param {!WebInspector.ResourceWebSocketFrameNode} b
  * @return {number}
  */
 WebInspector.ResourceWebSocketFrameNodeTimeComparator = function(a, b)
 {
     return a._frame.time - b._frame.time;
 }