Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1468623002: Revert "Fix test failures on the bots" (Closed)

Created:
5 years, 1 month ago by Brian Wilkerson
Modified:
5 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -83 lines) Patch
M pkg/analysis_server/test/abstract_context.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 2 chunks +1 line, -4 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 4 chunks +45 lines, -48 lines 0 comments Download
M pkg/analysis_server/test/domain_diagnostic_test.dart View 2 chunks +1 line, -5 lines 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/context/abstract_context.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/generate.dart View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 1 month ago (2015-11-20 22:02:15 UTC) #2
scheglov
LGTM
5 years, 1 month ago (2015-11-20 22:02:39 UTC) #3
Brian Wilkerson
5 years, 1 month ago (2015-11-20 22:04:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b2728c15a6470e2665240b03ea89d29f5e190618 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698