Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 1468583002: Add a unit index to prelinked type references in summaries. (Closed)

Created:
5 years, 1 month ago by Paul Berry
Modified:
5 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a unit index to prelinked type references in summaries. In order to avoid having to reconstitute the entire element model when deserializing a library summary, we'll need to be able to create element handles for any elements referenced by the library. Since element handles operate using a "location", and the "location" records information about the compilation unit containing the element, this means that the library summary needs to track which unit each referenced element lives in (even though this information would otherwise not be semantically relevant). R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/84c3cdb0487b2a4d546cf08a59607969d98fa533

Patch Set 1 #

Patch Set 2 : Remove an unnecessary TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -10 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 2 chunks +13 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 6 chunks +10 lines, -6 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 1 month ago (2015-11-20 21:19:31 UTC) #2
scheglov
LGTM
5 years, 1 month ago (2015-11-20 22:00:17 UTC) #3
Paul Berry
5 years, 1 month ago (2015-11-20 22:10:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
84c3cdb0487b2a4d546cf08a59607969d98fa533 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698