Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 146853004: Adding Chromium authors to the AUTHORS file (Closed)

Created:
6 years, 10 months ago by rmistry
Modified:
6 years, 10 months ago
Reviewers:
hcm
CC:
skia-review_googlegroups.com, skiabot_google.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Adding Chromium authors to the AUTHORS file. Some Googlers commit code into Skia using their chromium.org accounts. The Chromium AUTHORS file has a similar entry: http://src.chromium.org/viewvc/chrome/trunk/src/AUTHORS (SkipBuildbotRuns) NOTRY=true BUG=skia:2072 TBR= Committed: http://code.google.com/p/skia/source/detail?r=13271

Patch Set 1 #

Patch Set 2 : Sort #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M AUTHORS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
rmistry
6 years, 10 months ago (2014-01-31 19:04:51 UTC) #1
hcm
LGTM
6 years, 10 months ago (2014-01-31 19:09:24 UTC) #2
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 10 months ago (2014-01-31 19:10:17 UTC) #3
hcm
6 years, 10 months ago (2014-01-31 19:10:18 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-01-31 19:10:28 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-01-31 19:10:29 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 19:10:34 UTC) #7
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 10 months ago (2014-01-31 19:12:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/rmistry@google.com/146853004/30001
6 years, 10 months ago (2014-01-31 19:12:38 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 19:12:45 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 19:12:45 UTC) #11
Message was sent while issue was closed.
Change committed as 13271

Powered by Google App Engine
This is Rietveld 408576698