Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 1468513002: [tools/vim] Only run PRESUBMIT unittests for changes that touch YCM config. (Closed)

Created:
5 years, 1 month ago by asanka
Modified:
5 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/vim] Only run PRESUBMIT unittests for changes that touch YCM config. BUG=554183 Committed: https://crrev.com/167e1ea5c14c634c118c5155b5ab9daaab2902ee Cr-Commit-Position: refs/heads/master@{#360985}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M tools/vim/PRESUBMIT.py View 1 1 chunk +20 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
asanka
5 years, 1 month ago (2015-11-20 18:39:34 UTC) #2
Nico
rs-lgtm thanks!
5 years, 1 month ago (2015-11-20 22:38:52 UTC) #3
asanka
On 2015/11/20 at 22:38:52, thakis wrote: > rs-lgtm > > thanks! Thanks!
5 years, 1 month ago (2015-11-21 00:47:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468513002/20001
5 years, 1 month ago (2015-11-21 00:54:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-21 02:08:10 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 02:08:52 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/167e1ea5c14c634c118c5155b5ab9daaab2902ee
Cr-Commit-Position: refs/heads/master@{#360985}

Powered by Google App Engine
This is Rietveld 408576698