Add finch flag for rendering a recently closed link on the local ntp.

chrome/browser/search/local_ntp_source.cc

Index: chrome/browser/search/local_ntp_source.cc
diff --git a/chrome/browser/search/local_ntp_source.cc b/chrome/browser/search/local_ntp_source.cc
index 42a91740bccf0b0d14aa307f91593595a10f4af6..3eb2288a01cb71de19ff6aa0238e63c52acc4303 100644
--- a/chrome/browser/search/local_ntp_source.cc
+++ b/chrome/browser/search/local_ntp_source.cc
@@ -8,12 +8,17 @@
 #include "base/memory/ref_counted_memory.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
+#include "base/values.h"
+#include "chrome/browser/search/search.h"
 #include "chrome/common/url_constants.h"
 #include "googleurl/src/gurl.h"
 #include "grit/browser_resources.h"
+#include "grit/generated_resources.h"
 #include "grit/ui_resources.h"
 #include "net/url_request/url_request.h"
+#include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
+#include "ui/webui/jstemplate_builder.h"
 
 namespace {
 
@@ -50,6 +55,13 @@ std::string StripParameters(const std::string& path) {
   return path.substr(0, path.find("?"));
 }
 
+// Adds a localized string keyed by resource id to the dictionary.
+void AddString(base::DictionaryValue* dictionary,
+                const std::string& key,

[Jered, 2013/05/03 14:38:01]

deindent

[jeremycho, 2013/05/03 21:57:17]

Done.

+                int resource_id) {
+  dictionary->SetString(key, l10n_util::GetStringUTF16(resource_id));
+}
+
 }  // namespace
 
 LocalNtpSource::LocalNtpSource() {
@@ -70,10 +82,23 @@ void LocalNtpSource::StartDataRequest(
   const std::string stripped_path = StripParameters(path);
   for (size_t i = 0; i < arraysize(kResources); ++i) {
     if (stripped_path == kResources[i].filename) {
-      scoped_refptr<base::RefCountedStaticMemory> response(
-          ResourceBundle::GetSharedInstance().LoadDataResourceBytes(
-              kResources[i].identifier));
-      callback.Run(response);
+      if (stripped_path == "local-ntp.html") {

[Jered, 2013/05/03 14:38:01]

Make this a const char* and reference it here and in the other place in this
file where it's used.

[jeremycho, 2013/05/03 21:57:17]

Done.

+        base::DictionaryValue translated_strings;
+        if (chrome::ShouldShowRecentlyClosedOnNTP()) {
+          AddString(&translated_strings, "recentlyClosed",
+                    IDS_NEW_TAB_RECENTLY_CLOSED);
+        }
+        static const base::StringPiece html(ResourceBundle::GetSharedInstance()
+             .GetRawDataResource(kResources[i].identifier));
+        std::string i18n_html =
+            webui::GetI18nTemplateHtml(html, &translated_strings);

[Jered, 2013/05/03 14:38:01]

Ah, I bet you're running into a restriction against inline-script.

To get around this, you can add this to the local-ntp.html:
<script src="local-ntp-strings.js"></script>

Then here, when you get a request for local-ntp-strings.js, call
AppendJsonJS()
or similar to output an appropriate dictionary.

[jeremycho, 2013/05/03 21:57:17]

Yup, thanks for the pointer.  Done.

+        callback.Run(base::RefCountedString::TakeString(&i18n_html));
+      } else {
+        scoped_refptr<base::RefCountedStaticMemory> response(
+            ResourceBundle::GetSharedInstance().LoadDataResourceBytes(
+                kResources[i].identifier));
+        callback.Run(response);
+      }
       return;
     }
   }
@@ -105,6 +130,10 @@ bool LocalNtpSource::ShouldServiceRequest(
   return false;
 }
 
+bool LocalNtpSource::ShouldAddContentSecurityPolicy() const {
+ return false;

[Jered, 2013/05/03 14:38:01]

Don't do this. We're using CSP as a layer of defense for most
visited/suggestions. What restriction are you running into? We can relax the
policy, or find another way.

[jeremycho, 2013/05/03 21:57:17]

Removed

+}
+
 std::string LocalNtpSource::GetContentSecurityPolicyFrameSrc() const {
   // Allow embedding of chrome search suggestion host.
   return base::StringPrintf("frame-src %s://%s/;",