Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: components/scheduler/base/time_domain.cc

Issue 1468443002: Reduce the number of delayed tasks on chromium run loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a typo Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/base/time_domain.cc
diff --git a/components/scheduler/base/time_domain.cc b/components/scheduler/base/time_domain.cc
index 825812e43744907799923364dfc5c182a29548ec..73904ffa366fef87eb5c9fd54f8d07e07ee40f88 100644
--- a/components/scheduler/base/time_domain.cc
+++ b/components/scheduler/base/time_domain.cc
@@ -31,7 +31,7 @@ void TimeDomain::UnregisterQueue(internal::TaskQueueImpl* queue) {
}
}
- // |newly_updatable_| might contain |task_queue|, we use
+ // |newly_updatable_| might contain |queue|, we use
// MoveNewlyUpdatableQueuesIntoUpdatableQueueSet to flush it out.
MoveNewlyUpdatableQueuesIntoUpdatableQueueSet();
updatable_queue_set_.erase(queue);
@@ -66,12 +66,12 @@ void TimeDomain::ScheduleDelayedWork(internal::TaskQueueImpl* queue,
base::TimeTicks delayed_run_time,
LazyNow* lazy_now) {
DCHECK(main_thread_checker_.CalledOnValidThread());
- // Dedupe wakeups.
- if (delayed_wakeup_multimap_.find(delayed_run_time) ==
- delayed_wakeup_multimap_.end()) {
+
+ if (delayed_wakeup_multimap_.empty() ||
+ delayed_run_time < delayed_wakeup_multimap_.begin()->first) {
base::TimeDelta delay =
std::max(base::TimeDelta(), delayed_run_time - lazy_now->Now());
- RequestWakeup(delay);
+ RequestWakeup(lazy_now, delay);
}
delayed_wakeup_multimap_.insert(std::make_pair(delayed_run_time, queue));
}

Powered by Google App Engine
This is Rietveld 408576698