components/scheduler/base/task_queue_impl.cc - Issue 1468443002: Reduce the number of delayed tasks on chromium run loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/base/task_queue_impl.cc

Issue 1468443002: Reduce the number of delayed tasks on chromium run loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed a typo Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/scheduler/base/real_time_domain.cc ('K') | « components/scheduler/base/real_time_domain.cc ('k') | components/scheduler/base/task_queue_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/base/task_queue_impl.cc

diff --git a/components/scheduler/base/task_queue_impl.cc b/components/scheduler/base/task_queue_impl.cc

index a09e84da32190ae937afce0be47cc18a7a5d4e65..0ad965b00f774201920becfde5d0fb3b24faf0ae 100644

--- a/components/scheduler/base/task_queue_impl.cc

+++ b/components/scheduler/base/task_queue_impl.cc

@@ -325,10 +325,6 @@ void TaskQueueImpl::EnqueueDelayedTaskLocked(const Task& pending_task) {

return;

if (any_thread().incoming_queue.empty())

any_thread().time_domain->RegisterAsUpdatableTaskQueue(this);

- if (any_thread().pump_policy == PumpPolicy::AUTO &&

- any_thread().incoming_queue.empty()) {

- any_thread().task_queue_manager->MaybePostDoWorkOnMainRunner();

- }

// TODO(alexclarke): consider std::move() when allowed.

any_thread().incoming_queue.push(pending_task);

any_thread().incoming_queue.back().set_enqueue_order(