Allow arbitrary names for weak references in heap snapshots.

Allow arbitrary names for weak references in heap snapshots.

LOG=N
BUG=
R=ulan@chromium.org, yurys@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18846

[alph, 2014-01-27 09:14:58]

Folks could you please take a look. This is basically the same patch. I've just
have to put a dummy argument to the EXTRACT_CONTEXT_FIELD macro.

[ulan, 2014-01-27 09:24:22]

lgtm but I am not familiar with heap snapshot code, so please wait for approval
of other reviewers before landing.

https://codereview.chromium.org/146843003/diff/20001/src/heap-snapshot-genera...
File src/heap-snapshot-generator.cc (right):

https://codereview.chromium.org/146843003/diff/20001/src/heap-snapshot-genera...
src/heap-snapshot-generator.cc:1217:
EXTRACT_CONTEXT_FIELD(OPTIMIZED_FUNCTIONS_LIST, _,
Maybe name it dummy or unused to be more clear.

[alph, 2014-01-27 09:27:17]

https://codereview.chromium.org/146843003/diff/20001/src/heap-snapshot-genera...
File src/heap-snapshot-generator.cc (right):

https://codereview.chromium.org/146843003/diff/20001/src/heap-snapshot-genera...
src/heap-snapshot-generator.cc:1217:
EXTRACT_CONTEXT_FIELD(OPTIMIZED_FUNCTIONS_LIST, _,
On 2014/01/27 09:24:22, ulan wrote:
> Maybe name it dummy or unused to be more clear.

Done.

[yurys, 2014-01-27 09:31:35]

lgtm

[alph, 2014-01-27 09:37:11]

Committed patchset #4 manually as r18846 (presubmit successful).