Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/LayoutTests/fast/forms/select/popup-menu-mouse-operations.html

Issue 1468353002: New SELECT Popup: Do not select and scroll to an option of which visible area is less than 1px heig… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove a comment Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/popup-menu-mouse-operations-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/forms/select/popup-menu-mouse-operations.html
diff --git a/third_party/WebKit/LayoutTests/fast/forms/select/popup-menu-mouse-operations.html b/third_party/WebKit/LayoutTests/fast/forms/select/popup-menu-mouse-operations.html
index 4e5112027275670fd6f4abf14c335e6e9af148e6..22a3e23293b3bd46919f9e5503f36b64158d392e 100644
--- a/third_party/WebKit/LayoutTests/fast/forms/select/popup-menu-mouse-operations.html
+++ b/third_party/WebKit/LayoutTests/fast/forms/select/popup-menu-mouse-operations.html
@@ -11,8 +11,32 @@
<option selected>bar</option>
<option>baz</option>
</select>
+<select id="menu2" style="font-size:13px; font-family:Arial">
+ <option>option1</option>
+ <option>option2</option>
+ <option>option3</option>
+ <option>option4</option>
+ <option>option5</option>
+ <option>option6</option>
+ <option>option7</option>
+ <option>option8</option>
+ <option>option9</option>
+ <option>option10</option>
+ <option>option11</option>
+ <option>option12</option>
+ <option>option13</option>
+ <option>option14</option>
+ <option>option15</option>
+ <option>option16</option>
+ <option>option17</option>
+ <option>option18</option>
+ <option>option19</option>
+ <option>option20</option>
+ <option>option21</option>
+</select>
<script>
var menuElement = document.getElementById('menu');
+var menuElement2 = document.getElementById('menu2');
var picker = null;
var clickEventCounter = 0;
menuElement.addEventListener('click', function() { clickEventCounter++; }, false);
@@ -84,6 +108,18 @@ function test2() {
shouldBeEqualToString('menu.value', 'bar');
shouldBeEqualToString('internals.selectMenuListText(menu)', 'bar');
+ waitUntilClosing(function() {
+ openPicker(menu2, test3, openPickerErrorCallback);
+ });
+}
+
+function test3() {
+ picker = window.internals.pagePopupWindow.global.picker;
+ // We had a bug that almost-invisible OPTION was selected and the popup was
+ // scrolled. crbug.com/558287.
+ eventSender.mouseMoveTo(10, picker._selectElement.offsetHeight - 2);
+ shouldBeEqualToString('picker._selectElement.selectedOptions[0].label', 'option20');
+
finishJSTest();
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/popup-menu-mouse-operations-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698