New SELECT Popup: Do not select and scroll to an option of which visible area is less than 1px heig…

third_party/WebKit/Source/web/resources/listPicker.js

Index: third_party/WebKit/Source/web/resources/listPicker.js
diff --git a/third_party/WebKit/Source/web/resources/listPicker.js b/third_party/WebKit/Source/web/resources/listPicker.js
index 167ad3cd77cc1ceb90b253edb6253f6541488ac0..b47b9d0bdbe9110d84bfd2871d6abdc52e5adc3c 100644
--- a/third_party/WebKit/Source/web/resources/listPicker.js
+++ b/third_party/WebKit/Source/web/resources/listPicker.js
@@ -87,7 +87,27 @@ ListPicker.prototype._handleWindowMessage = function(event) {
     delete window.updateData;
 };
 
+// This should be matched to the border width of the internal listbox
+// SELECT. See listPicker.css and html.css.
+ListPicker.ListboxSelectBorder = 1;
+
 ListPicker.prototype._handleWindowMouseMove = function (event) {
+    // |selectBorder| should be matched the border-width of the internal SELECT
+    // |element.

[keishi, 2015/11/24 09:52:32]

nit: extra comment

[tkent, 2015/11/24 12:23:41]

Removed.

+    var visibleTop = ListPicker.ListboxSelectBorder;
+    var visibleBottom = this._selectElement.offsetHeight - ListPicker.ListboxSelectBorder;
+    var optionBounds = event.target.getBoundingClientRect();
+    if (optionBounds.height >= 1.0) {
+        // If the height of the visible part of event.target is less than 1px,
+        // ignore this event because it may be an error by sub-pixel layout.
+        if (optionBounds.top < visibleTop) {
+            if (optionBounds.bottom - visibleTop < 1.0)
+                return;
+        } else if (optionBounds.bottom > visibleBottom) {
+            if (visibleBottom - optionBounds.top < 1.0)
+                return;
+        }
+    }
     this.lastMousePositionX = event.clientX;
     this.lastMousePositionY = event.clientY;
     this._highlightOption(event.target);
@@ -194,10 +214,7 @@ ListPicker.prototype._handleKeyDown = function(event) {
 ListPicker.prototype._fixWindowSize = function() {
     this._selectElement.style.height = "";
     var maxHeight = this._selectElement.offsetHeight;
-    // heightOutsideOfContent should be matched to border widths of the listbox
-    // SELECT. See listPicker.css and html.css.
-    var heightOutsideOfContent = 2;
-    var noScrollHeight = Math.round(this._calculateScrollHeight() + heightOutsideOfContent);
+    var noScrollHeight = Math.round(this._calculateScrollHeight() + ListPicker.ListboxSelectBorder * 2);
     var desiredWindowHeight = noScrollHeight;
     var desiredWindowWidth = this._selectElement.offsetWidth;
     var expectingScrollbar = false;