Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1468353002: New SELECT Popup: Do not select and scroll to an option of which visible area is less than 1px heig… (Closed)

Created:
5 years ago by tkent
Modified:
5 years ago
Reviewers:
keishi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

New SELECT Popup: Do not select and scroll to an option of which visible area is less than 1px height. BUG=558287 TEST=automated Committed: https://crrev.com/cdc30810519e701c8ec47fd60eaf489cd5ab588a Cr-Commit-Position: refs/heads/master@{#361332}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : remove a comment #

Messages

Total messages: 11 (5 generated)
tkent
Keishi, would you review this please?
5 years ago (2015-11-24 08:40:48 UTC) #4
keishi
LGTM https://codereview.chromium.org/1468353002/diff/40001/third_party/WebKit/Source/web/resources/listPicker.js File third_party/WebKit/Source/web/resources/listPicker.js (right): https://codereview.chromium.org/1468353002/diff/40001/third_party/WebKit/Source/web/resources/listPicker.js#newcode96 third_party/WebKit/Source/web/resources/listPicker.js:96: // |element. nit: extra comment
5 years ago (2015-11-24 09:52:32 UTC) #5
tkent
Thank you! https://codereview.chromium.org/1468353002/diff/40001/third_party/WebKit/Source/web/resources/listPicker.js File third_party/WebKit/Source/web/resources/listPicker.js (right): https://codereview.chromium.org/1468353002/diff/40001/third_party/WebKit/Source/web/resources/listPicker.js#newcode96 third_party/WebKit/Source/web/resources/listPicker.js:96: // |element. On 2015/11/24 at 09:52:32, keishi ...
5 years ago (2015-11-24 12:23:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468353002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468353002/60001
5 years ago (2015-11-24 12:24:01 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years ago (2015-11-24 13:51:24 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-24 13:52:01 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cdc30810519e701c8ec47fd60eaf489cd5ab588a
Cr-Commit-Position: refs/heads/master@{#361332}

Powered by Google App Engine
This is Rietveld 408576698