Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 146833020: Remove some uses of ATL in UI code (Closed)

Created:
6 years, 10 months ago by scottmg
Modified:
6 years, 10 months ago
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, tfarina, kalyank
Visibility:
Public.

Description

Remove some uses of ATL in UI code Started by trying to remove only atlbase.h, but atlcrack.h (WTL) uses CPoint/CSize, etc from ATL. So, msg_util.h is atlcrack.h, but adapted to use gfx types, and with CR_ prefix on crack macros for now. R=ben@chromium.org BUG=5027, 323300 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247637

Patch Set 1 #

Patch Set 2 : reitveld #

Patch Set 3 : mojo #

Patch Set 4 : various mopping #

Patch Set 5 : more mojo #

Patch Set 6 : and more #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2465 lines, -176 lines) Patch
M mojo/services/native_viewport/native_viewport_win.cc View 1 2 3 4 2 chunks +16 lines, -15 lines 0 comments Download
M tools/memory_watcher/dllmain.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M tools/memory_watcher/hotkey.h View 1 2 3 3 chunks +7 lines, -5 lines 0 comments Download
M tools/memory_watcher/memory_watcher.gyp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/root_window_host_win.h View 1 chunk +22 lines, -20 lines 0 comments Download
M ui/aura/root_window_host_win.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/base/win/foreground_helper.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/win/foreground_helper.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M ui/base/win/hidden_window.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/compositor/test/test_compositor_host_win.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A ui/gfx/win/msg_util.h View 1 2 3 4 5 1 chunk +2283 lines, -0 lines 0 comments Download
M ui/gfx/win/window_impl.h View 1 chunk +1 line, -5 lines 0 comments Download
M ui/views/win/hwnd_message_handler.h View 5 chunks +71 lines, -72 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 2 3 4 5 6 22 chunks +47 lines, -35 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scottmg
6 years, 10 months ago (2014-01-28 22:36:12 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 10 months ago (2014-01-29 00:27:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/146833020/100001
6 years, 10 months ago (2014-01-29 00:32:48 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) check_deps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=219970
6 years, 10 months ago (2014-01-29 02:04:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/146833020/120001
6 years, 10 months ago (2014-01-29 02:48:55 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=253295
6 years, 10 months ago (2014-01-29 04:14:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/146833020/120001
6 years, 10 months ago (2014-01-29 04:39:53 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 06:00:31 UTC) #8
Message was sent while issue was closed. 
Change committed as 247637

Powered by Google App Engine
This is Rietveld 408576698