LayoutTests/fast/css-grid-layout/flex-content-sized-column-use-available-width.html - Issue 146833018: [CSS Grid Layout] Fix missing layout in flexible and content sized columns

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/flex-content-sized-column-use-available-width.html

Issue 146833018: [CSS Grid Layout] Fix missing layout in flexible and content sized columns (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Move check to RenderGrid::resolveContentBasedTrackSizingFunctions() Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/flex-content-sized-column-use-available-width-expected.html » ('j') | LayoutTests/fast/css-grid-layout/flex-content-sized-columns-resize.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <link href="resources/grid.css" rel="stylesheet">

	5 <style type="text/css">

	6 #grid-1 {

	7 grid-template-columns: 1fr;

	8 }

	9

	10 #grid-2 {

	11 grid-template-columns: auto;

	12 }

	13 </style>

	14 </head>

	15 <body>

	16 <h1>Description</h1>

	17 <p>Flex and content sized column should use all the available width and you should not see the grid background (grey at the end).</p>

	18 <h1>Grid 1 flex column</h1>

	19 <div id="grid-1" class="grid">

	20 <div class="firstRowFirstColumn">grid item</div>

	21 </div>

	22 <h1>Grid 1 auto column</h1>

	23 <div id="grid-2" class="grid">

	24 <div class="firstRowFirstColumn">

	25 grid item grid item grid item grid item grid item grid item grid ite m grid item grid item grid item

	26 grid item grid item grid item grid item grid item grid item grid ite m grid item grid item grid item

	27 grid item grid item grid item grid item grid item grid item grid ite m grid item grid item grid item

	28 grid item grid item grid item grid item grid item grid item grid ite m grid item grid item grid item

	29 </div>

	30 </div>

	31 </body>

	32 </html>

OLD	NEW