dartfmt line length command line option support.

dartfmt line length command line option support.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32027

[Brian Wilkerson, 2014-01-27 18:38:41]

LGTM

https://codereview.chromium.org/146833014/diff/1/pkg/analyzer/bin/formatter.dart
File pkg/analyzer/bin/formatter.dart (right):

https://codereview.chromium.org/146833014/diff/1/pkg/analyzer/bin/formatter.d...
pkg/analyzer/bin/formatter.dart:161: parser.addOption(MAX_LINE_FLAG, abbr: 'l',
defaultsTo: '80',
Do we want to support an easy way to not wrap lines (as opposed to setting some
ridiculously long line length and hoping it's long enough)?

[pquitslund, 2014-01-27 19:06:03]

https://codereview.chromium.org/146833014/diff/1/pkg/analyzer/bin/formatter.dart
File pkg/analyzer/bin/formatter.dart (right):

https://codereview.chromium.org/146833014/diff/1/pkg/analyzer/bin/formatter.d...
pkg/analyzer/bin/formatter.dart:161: parser.addOption(MAX_LINE_FLAG, abbr: 'l',
defaultsTo: '80',
On 2014/01/27 18:38:42, Brian Wilkerson wrote:
> Do we want to support an easy way to not wrap lines (as opposed to setting
some
> ridiculously long line length and hoping it's long enough)?

Maybe.  I'd rather not add another flag.  Do you think a value like -1 is too
opaque?

[pquitslund, 2014-01-27 19:06:22]

Committed patchset #1 manually as r32027 (presubmit successful).

[Brian Wilkerson, 2014-01-27 19:12:27]

https://codereview.chromium.org/146833014/diff/1/pkg/analyzer/bin/formatter.dart
File pkg/analyzer/bin/formatter.dart (right):

https://codereview.chromium.org/146833014/diff/1/pkg/analyzer/bin/formatter.d...
pkg/analyzer/bin/formatter.dart:161: parser.addOption(MAX_LINE_FLAG, abbr: 'l',
defaultsTo: '80',
> Maybe.  I'd rather not add another flag.

I agree. Especially since it would then be possible to specify conflicting
options.

> Do you think a value like -1 is too opaque?

Not if you mention it in the help description. (Although "0" would work just as
well and might be easier to parse.)