Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: base/test/sequenced_task_runner_test_template.h

Issue 146833008: Threading: Remove TaskRunnerHandlesNonZeroDelays from TaskRunnerTestDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/test/task_runner_test_template.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/sequenced_task_runner_test_template.h
diff --git a/base/test/sequenced_task_runner_test_template.h b/base/test/sequenced_task_runner_test_template.h
index dacbb999e8d0fc8e784f613cae408362fcecbd4b..48f5354d9b594aa8ab50170162884c00f0fc22b5 100644
--- a/base/test/sequenced_task_runner_test_template.h
+++ b/base/test/sequenced_task_runner_test_template.h
@@ -178,13 +178,6 @@ TYPED_TEST_P(SequencedTaskRunnerTest, SequentialNestable) {
// that that the tasks are run in FIFO order and that there is no execution
// overlap whatsoever between any two tasks.
TYPED_TEST_P(SequencedTaskRunnerTest, SequentialDelayedNonNestable) {
- // TODO(akalin): Remove this check (http://crbug.com/149144).
- if (!this->delegate_.TaskRunnerHandlesNonZeroDelays()) {
- DLOG(INFO) << "This SequencedTaskRunner doesn't handle "
- "non-zero delays; skipping";
- return;
- }
-
const int kTaskCount = 20;
const int kDelayIncrementMs = 50;
@@ -236,13 +229,6 @@ TYPED_TEST_P(SequencedTaskRunnerTest, NonNestablePostFromNonNestableTask) {
// This test posts a delayed task, and checks that the task is run later than
// the specified time.
TYPED_TEST_P(SequencedTaskRunnerTest, DelayedTaskBasic) {
- // TODO(akalin): Remove this check (http://crbug.com/149144).
- if (!this->delegate_.TaskRunnerHandlesNonZeroDelays()) {
- DLOG(INFO) << "This SequencedTaskRunner doesn't handle "
- "non-zero delays; skipping";
- return;
- }
-
const int kTaskCount = 1;
const TimeDelta kDelay = TimeDelta::FromMilliseconds(100);
@@ -270,13 +256,6 @@ TYPED_TEST_P(SequencedTaskRunnerTest, DelayedTaskBasic) {
// posted at the exact same time. It would be nice if the API allowed us to
// specify the desired run time.
TYPED_TEST_P(SequencedTaskRunnerTest, DelayedTasksSameDelay) {
- // TODO(akalin): Remove this check (http://crbug.com/149144).
- if (!this->delegate_.TaskRunnerHandlesNonZeroDelays()) {
- DLOG(INFO) << "This SequencedTaskRunner doesn't handle "
- "non-zero delays; skipping";
- return;
- }
-
const int kTaskCount = 2;
const TimeDelta kDelay = TimeDelta::FromMilliseconds(100);
@@ -299,13 +278,6 @@ TYPED_TEST_P(SequencedTaskRunnerTest, DelayedTasksSameDelay) {
// delayed task runs after the normal task even if the normal task takes
// a long time to run.
TYPED_TEST_P(SequencedTaskRunnerTest, DelayedTaskAfterLongTask) {
- // TODO(akalin): Remove this check (http://crbug.com/149144).
- if (!this->delegate_.TaskRunnerHandlesNonZeroDelays()) {
- DLOG(INFO) << "This SequencedTaskRunner doesn't handle "
- "non-zero delays; skipping";
- return;
- }
-
const int kTaskCount = 2;
this->delegate_.StartTaskRunner();
@@ -327,13 +299,6 @@ TYPED_TEST_P(SequencedTaskRunnerTest, DelayedTaskAfterLongTask) {
// Test that a pile of normal tasks and a delayed task run in the
// time-to-run order.
TYPED_TEST_P(SequencedTaskRunnerTest, DelayedTaskAfterManyLongTasks) {
- // TODO(akalin): Remove this check (http://crbug.com/149144).
- if (!this->delegate_.TaskRunnerHandlesNonZeroDelays()) {
- DLOG(INFO) << "This SequencedTaskRunner doesn't handle "
- "non-zero delays; skipping";
- return;
- }
-
const int kTaskCount = 11;
this->delegate_.StartTaskRunner();
« no previous file with comments | « no previous file | base/test/task_runner_test_template.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698