Don’t call toString from debugger

runtime/bin/dbg_message.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dbg_connection.h"
 #include "bin/dbg_message.h"
 #include "bin/dartutils.h"
 #include "bin/thread.h"
 #include "bin/utils.h"
 
@@ skipping 183 matching lines @@
     }
   }
   buf->Printf("]");
 }
 
 
 static void FormatTextualValue(dart::TextBuffer* buf,
                                Dart_Handle object,
                                intptr_t max_chars,
                                bool expand_list) {
+  ASSERT(!Dart_IsError(object));
   if (Dart_IsList(object)) {
     if (expand_list) {
       FormatTextualListValue(buf, object, max_chars);
     } else {
       buf->Printf("[...]");
     }
   } else if (Dart_IsNull(object)) {
     buf->Printf("null");
   } else if (Dart_IsString(object)) {
     buf->Printf("\\\"");
     FormatEncodedCharsTrunc(buf, object, max_chars);
     buf->Printf("\\\"");
+  } else if (Dart_IsNumber(object) || Dart_IsBoolean(object)) {
+    Dart_Handle text = Dart_ToString(object);
+    ASSERT(!Dart_IsNull(text) && !Dart_IsError(text));
+    FormatEncodedCharsTrunc(buf, text, max_chars);
   } else {
-    Dart_Handle text = Dart_ToString(object);
-    if (Dart_IsNull(text)) {
-      buf->Printf("null");
-    } else if (Dart_IsError(text)) {
-      buf->Printf("#ERROR");
-    } else {
-      FormatEncodedCharsTrunc(buf, text, max_chars);
-    }
+    Dart_Handle type = Dart_InstanceGetType(object);
+    ASSERT_NOT_ERROR(type);
+    type = Dart_ToString(type);
+    ASSERT_NOT_ERROR(type);
+    buf->Printf("object of type ");
+    FormatEncodedCharsTrunc(buf, type, max_chars);
   }
 }
 
 
 static void FormatValue(dart::TextBuffer* buf, Dart_Handle object) {
   bool print_text_field = true;
   if (Dart_IsNumber(object)) {
     buf->Printf("\"kind\":\"number\"");
   } else if (Dart_IsString(object)) {
     buf->Printf("\"kind\":\"string\"");
@@ skipping 1131 matching lines @@
     } else {
       ASSERT(kind == kShutdown);
       RemoveIsolateMsgQueue(isolate_id);
     }
   }
   Dart_ExitScope();
 }
 
 }  // namespace bin
 }  // namespace dart