Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1468313004: Make fast_exp take an Isolate* paramter (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make fast_exp take an Isolate* paramter We still share the code globally, but if we wanted, it would be easy to make it per isolate now BUG=v8:2487 R=yangguo@chromium.org,jkummerow@chromium.org LOG=n Committed: https://crrev.com/0fb2edd15dd108e54c73dd413dff6e192fb7ec0c Cr-Commit-Position: refs/heads/master@{#32217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -70 lines) Patch
M src/arm/codegen-arm.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M src/arm64/codegen-arm64.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M src/codegen.h View 1 chunk +4 lines, -3 lines 0 comments Download
M src/codegen.cc View 1 chunk +21 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M src/mips/codegen-mips.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M src/mips64/codegen-mips64.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M src/ppc/codegen-ppc.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/codegen-x64.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M src/x87/codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-11-24 13:56:45 UTC) #1
Yang
On 2015/11/24 13:56:45, jochen wrote: lgtm.
5 years ago (2015-11-24 14:10:07 UTC) #2
Toon Verwaest
lgtm
5 years ago (2015-11-24 14:20:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468313004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468313004/1
5 years ago (2015-11-24 14:34:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 15:34:23 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-24 15:34:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fb2edd15dd108e54c73dd413dff6e192fb7ec0c
Cr-Commit-Position: refs/heads/master@{#32217}

Powered by Google App Engine
This is Rietveld 408576698