Issue 14683012: Merge 198707 "Record first run startup metrics."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14683012: Merge 198707 "Record first run startup metrics." (Closed)

Created:
7 years, 7 months ago by gab

Modified:
7 years, 7 months ago

Reviewers:
gab

CC:
chromium-reviews, tfarina, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1500/src/

Visibility:
Public.

Merge 198707 "Record first run startup metrics." > Record first run startup metrics. > > Also fixing first run code to only call startup_metric_utils::SetNonBrowserUIDisplayed() if the dialog is actually displayed (which it isn't in many situations). > > NOTRY=True (patchset 6 already passed all the try bots, simply updating a string in patchset 7) > BUG=237933, 219419 > > Review URL: https://chromiumcodereview.appspot.com/14946003 TBR=gab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199533

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -71 lines)			Patch
M	chrome/browser/chrome_browser_main.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chrome_browser_main.cc	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/first_run/first_run.cc	View	4 chunks	+1 line, -13 lines	0 comments	Download
M	chrome/browser/first_run/first_run_dialog.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/first_run/first_run_internal.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/first_run/first_run_posix.cc	View	3 chunks	+19 lines, -1 line	0 comments	Download
M	chrome/browser/first_run/first_run_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/first_run_dialog.mm	View	4 chunks	+8 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/first_run_dialog.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/first_run_dialog.cc	View	4 chunks	+18 lines, -34 lines	0 comments	Download
M	chrome/browser/ui/views/first_run_bubble.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/startup_metric_utils.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/startup_metric_utils.cc	View	2 chunks	+10 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r199533.