Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 14683006: Removed CSS Variables flag (Closed)

Created:
7 years, 7 months ago by alancutter (OOO until 2018)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Removed CSS Variables flag Part 1 of transferring the CSS variables flag over to Blink's RuntimeEnabledFeatures flags. BUG=239748 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/webpreferences.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
alancutter (OOO until 2018)
This flag needs to be removed in Chromium before it can be changed in Blink ...
7 years, 7 months ago (2013-05-10 07:58:15 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 7 months ago (2013-05-14 16:47:54 UTC) #2
darin (slow to review)
LGTM
7 years, 7 months ago (2013-05-14 17:05:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/14683006/1
7 years, 7 months ago (2013-05-15 00:06:40 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=148788
7 years, 7 months ago (2013-05-15 06:42:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/14683006/1
7 years, 7 months ago (2013-05-15 13:44:18 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-15 18:18:57 UTC) #7
Message was sent while issue was closed.
Change committed as 200318

Powered by Google App Engine
This is Rietveld 408576698