Update code editor whitelist ID for developerPrivate API.

Update code editor whitelist ID for developerPrivate API.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199051

[miket_OOO, 2013-05-06 18:34:35]

lgtm

https://codereview.chromium.org/14683005/diff/1/chrome/common/extensions/api/...
File chrome/common/extensions/api/_permission_features.json (right):

https://codereview.chromium.org/14683005/diff/1/chrome/common/extensions/api/...
chrome/common/extensions/api/_permission_features.json:127:
"cbelnpbjogfbjamhpbofhlnklecjpido" // Apps Editor published.
Please add a personal TODO for yourself to remember to clean this up. Also note:
need two spaces before //.

[commit-bot: I haz the power, 2013-05-07 18:54:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/14683005/5001

[commit-bot: I haz the power, 2013-05-07 18:54:04]

Failed to apply patch for
chrome/browser/extensions/api/developer_private/developer_private_api.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/extensions/api/developer_private/developer_private_api.cc
  Hunk #1 succeeded at 108 with fuzz 1 (offset 11 lines).
  Hunk #2 succeeded at 1023 with fuzz 2 (offset 177 lines).
  Hunk #3 FAILED at 889.
  Hunk #4 FAILED at 1116.
  2 out of 4 hunks FAILED -- saving rejects to file
chrome/browser/extensions/api/developer_private/developer_private_api.cc.rej

Patch:      
chrome/browser/extensions/api/developer_private/developer_private_api.cc
Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc
diff --git
a/chrome/browser/extensions/api/developer_private/developer_private_api.cc
b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
index
28b9398fd3af074f2eab9a528b3c193de14d1aa4..0ddd96776af6cba572a526acd32dea4e63cfed39
100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
@@ -97,6 +97,18 @@ bool ValidateFolderName(const base::FilePath::StringType&
name) {
   return name == name_sanitized;
 }
 
+const Extension* GetExtensionByPath(const ExtensionSet* extensions,
+                                    const base::FilePath& path) {
+  base::FilePath extension_path = base::MakeAbsoluteFilePath(path);
+  for (ExtensionSet::const_iterator iter = extensions->begin();
+       iter != extensions->end(); ++iter) {
+    if ((*iter)->path() == extension_path) {
+      return *iter;
+    }
+  }
+  return NULL;
+}
+
 }  // namespace
 
 namespace AllowFileAccess = api::developer_private::AllowFileAccess;
@@ -834,7 +846,7 @@ void DeveloperPrivateExportSyncfsFolderToLocalfsFunction::
   fileapi::FileSystemURL url(sync_file_system::CreateSyncableFileSystemURL(
       GURL(origin_url),
       sync_file_system::DriveFileSyncService::kServiceName,
-      base::FilePath()));
+      project_path.BaseName()));
 
   base::PlatformFileError error_code;
   fileapi::FileSystemOperation* op =
@@ -877,7 +889,7 @@ void DeveloperPrivateExportSyncfsFolderToLocalfsFunction::
     fileapi::FileSystemURL url(sync_file_system::CreateSyncableFileSystemURL(
         GURL(origin_url),
         sync_file_system::DriveFileSyncService::kServiceName,
-        base::FilePath(file_list[i].name)));
+        project_path.BaseName().Append(file_list[i].name)));
     base::FilePath target_path = project_path;
     target_path = target_path.Append(file_list[i].name);
 
@@ -1104,10 +1116,34 @@ bool DeveloperPrivateLoadProjectFunction::RunImpl() {
   path = path.Append(project_name);
   ExtensionService* service = profile()->GetExtensionService();
   UnpackedInstaller::Create(service)->Load(path);
-  SendResponse(true);
+
+  const ExtensionSet* extensions = service->extensions();
+  // Released by GetUnpackedExtension.
+  AddRef();
+  content::BrowserThread::PostTask(content::BrowserThread::FILE, FROM_HERE,
+      base::Bind(&DeveloperPrivateLoadProjectFunction::GetUnpackedExtension,
+                 this, path, extensions));
   return true;
 }
 
+void DeveloperPrivateLoadProjectFunction::GetUnpackedExtension(
+    const base::FilePath& path,
+    const ExtensionSet* extensions) {
+  const Extension* extension = GetExtensionByPath(extensions, path);
+  bool success = true;
+  if (extension) {
+    SetResult(base::Value::CreateStringValue(extension->id()));
+  } else {
+    SetError("unable to load the project");
+    success = false;
+  }
+  content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
+      base::Bind(&DeveloperPrivateLoadProjectFunction::SendResponse,
+                 this,
+                 success));
+  Release();
+}
+
 DeveloperPrivateLoadProjectFunction::DeveloperPrivateLoadProjectFunction() {}
 
 DeveloperPrivateLoadProjectFunction::~DeveloperPrivateLoadProjectFunction() {}

[commit-bot: I haz the power, 2013-05-07 22:09:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/14683005/10001

[commit-bot: I haz the power, 2013-05-08 23:32:13]

Change committed as 199051