Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 14683005: Update code editor whitelist ID for developerPrivate API. (Closed)

Created:
7 years, 7 months ago by Gaurav
Modified:
7 years, 7 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@launch
Visibility:
Public.

Description

Update code editor whitelist ID for developerPrivate API. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199051

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/common/extensions/api/_permission_features.json View 1 2 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Gaurav
7 years, 7 months ago (2013-05-03 23:25:53 UTC) #1
miket_OOO
lgtm https://codereview.chromium.org/14683005/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/14683005/diff/1/chrome/common/extensions/api/_permission_features.json#newcode127 chrome/common/extensions/api/_permission_features.json:127: "cbelnpbjogfbjamhpbofhlnklecjpido" // Apps Editor published. Please add a ...
7 years, 7 months ago (2013-05-06 18:34:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/14683005/5001
7 years, 7 months ago (2013-05-07 18:54:02 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/extensions/api/developer_private/developer_private_api.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-07 18:54:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/14683005/10001
7 years, 7 months ago (2013-05-07 22:09:28 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-08 23:32:13 UTC) #6
Message was sent while issue was closed.
Change committed as 199051

Powered by Google App Engine
This is Rietveld 408576698