Ensure that a complete library element has constants evaluated (issue 24890)

pkg/analyzer/tool/task_dependency_graph/tasks.dot

Index: pkg/analyzer/tool/task_dependency_graph/tasks.dot
diff --git a/pkg/analyzer/tool/task_dependency_graph/tasks.dot b/pkg/analyzer/tool/task_dependency_graph/tasks.dot
index 7afcf7683e5dd1b2b738ed6a5998421e4491adf9..014e7928c7bdf3e48f0400dc736f8a58b1b69208 100644
--- a/pkg/analyzer/tool/task_dependency_graph/tasks.dot
+++ b/pkg/analyzer/tool/task_dependency_graph/tasks.dot
@@ -101,7 +101,6 @@ digraph G {
   LIBRARY_CYCLE_UNITS -> ResolveInstanceFieldsInUnitTask
   LIBRARY_CYCLE_UNITS -> ResolveUnitTask
   LIBRARY_CYCLE_UNITS [shape=box]
-  LIBRARY_ELEMENT -> EvaluateUnitConstantsTask
   LIBRARY_ELEMENT [shape=box]
   LIBRARY_ELEMENT1 -> BuildDirectiveElementsTask
   LIBRARY_ELEMENT1 -> ResolveVariableReferencesTask
@@ -121,13 +120,16 @@ digraph G {
   LIBRARY_ELEMENT5 -> PropagateVariableTypesInLibraryTask
   LIBRARY_ELEMENT5 -> ReadyLibraryElement5Task
   LIBRARY_ELEMENT5 -> ResolveInstanceFieldsInUnitTask
-  LIBRARY_ELEMENT5 -> ResolveLibraryReferencesTask
   LIBRARY_ELEMENT5 [shape=box]
   LIBRARY_ELEMENT6 -> PropagateVariableTypesInLibraryClosureTask
   LIBRARY_ELEMENT6 -> ReadyLibraryElement6Task
   LIBRARY_ELEMENT6 [shape=box]
+  LIBRARY_ELEMENT7 -> ResolveLibraryReferencesTask
   LIBRARY_ELEMENT7 -> ResolveUnitTask
   LIBRARY_ELEMENT7 [shape=box]
+  LIBRARY_ELEMENT8 -> EvaluateUnitConstantsTask
+  LIBRARY_ELEMENT8 -> ResolveLibraryTask
+  LIBRARY_ELEMENT8 [shape=box]
   LIBRARY_ERRORS_READY [shape=box]
   LIBRARY_SPECIFIC_UNITS -> GenerateHintsTask
   LIBRARY_SPECIFIC_UNITS -> PropagateVariableTypesInLibraryTask
@@ -135,6 +137,7 @@ digraph G {
   LIBRARY_SPECIFIC_UNITS -> ReadyResolvedUnit11Task
   LIBRARY_SPECIFIC_UNITS -> ReadyResolvedUnitTask
   LIBRARY_SPECIFIC_UNITS -> ResolveLibraryReferencesTask
+  LIBRARY_SPECIFIC_UNITS -> ResolveLibraryTask
   LIBRARY_SPECIFIC_UNITS -> ResolveLibraryTypeNamesTask
   LIBRARY_SPECIFIC_UNITS [shape=box]
   LIBRARY_UNIT_ERRORS -> dartErrorsForUnit
@@ -190,6 +193,7 @@ digraph G {
   READY_RESOLVED_UNIT10 -> ResolveLibraryReferencesTask
   READY_RESOLVED_UNIT10 [shape=box]
   READY_RESOLVED_UNIT11 -> ReadyResolvedUnit11Task
+  READY_RESOLVED_UNIT11 -> ResolveLibraryTask
   READY_RESOLVED_UNIT11 -> StrongModeVerifyUnitTask
   READY_RESOLVED_UNIT11 [shape=box]
   REFERENCED_NAMES [shape=box]
@@ -210,6 +214,7 @@ digraph G {
   RESOLVED_UNIT10 -> ResolveLibraryReferencesTask
   RESOLVED_UNIT10 [shape=box]
   RESOLVED_UNIT11 -> ReadyResolvedUnit11Task
+  RESOLVED_UNIT11 -> ResolveLibraryTask
   RESOLVED_UNIT11 -> StrongModeVerifyUnitTask
   RESOLVED_UNIT11 [shape=box]
   RESOLVED_UNIT2 -> ResolveUnitTypeNamesTask
@@ -249,8 +254,9 @@ digraph G {
   ReadyResolvedUnit11Task -> READY_RESOLVED_UNIT11
   ReadyResolvedUnitTask -> READY_RESOLVED_UNIT
   ResolveInstanceFieldsInUnitTask -> RESOLVED_UNIT8
-  ResolveLibraryReferencesTask -> LIBRARY_ELEMENT
+  ResolveLibraryReferencesTask -> LIBRARY_ELEMENT8
   ResolveLibraryReferencesTask -> REFERENCED_NAMES
+  ResolveLibraryTask -> LIBRARY_ELEMENT
   ResolveLibraryTypeNamesTask -> LIBRARY_ELEMENT5
   ResolveUnitTask -> RESOLVED_UNIT10
   ResolveUnitTask -> RESOLVE_UNIT_ERRORS