Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1468293003: Ensure that a complete library element has constants evaluated (issue 24890) (Closed)

Created:
5 years ago by Brian Wilkerson
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure that a complete library element has constants evaluated (issue 24890) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c8cec941efbfb0f17972945cf078efebdd39404c

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -12 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 8 chunks +84 lines, -6 lines 2 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 3 chunks +0 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 3 chunks +28 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/tasks.dot View 6 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years ago (2015-11-24 22:09:35 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1468293003/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/1468293003/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode4587 pkg/analyzer/lib/src/task/dart.dart:4587: UNITS_INPUT: LIBRARY_SPECIFIC_UNITS.of(source).toListOf(RESOLVED_UNIT11), This input is not used.
5 years ago (2015-11-24 22:17:23 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as c8cec941efbfb0f17972945cf078efebdd39404c (presubmit successful).
5 years ago (2015-11-25 14:37:49 UTC) #4
Brian Wilkerson
5 years ago (2015-11-25 14:44:41 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1468293003/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1468293003/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:4587: UNITS_INPUT:
LIBRARY_SPECIFIC_UNITS.of(source).toListOf(RESOLVED_UNIT11),
Removed

Powered by Google App Engine
This is Rietveld 408576698