Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1468273005: PPC: [compiler] No need to push literal index in VisitArrayLiteral. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [compiler] No need to push literal index in VisitArrayLiteral. Port 9846f386f08e2aaf897851f0f54c0967c51484fb Original commit message: The literal index is being pushed onto the stack while evaluating the non-constant subexpressions, but never used in fullcodegen (and hence not used in the optimizing compilers). R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/443fb4de8ebc375482a8277995782ec63ae26528 Cr-Commit-Position: refs/heads/master@{#32229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
MTBrandyberry
5 years ago (2015-11-24 19:12:52 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468273005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468273005/1
5 years ago (2015-11-24 20:00:18 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-24 20:48:54 UTC) #5
michael_dawson
On 2015/11/24 20:48:54, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years ago (2015-11-24 21:14:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468273005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468273005/1
5 years ago (2015-11-24 21:25:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 21:26:28 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-24 21:26:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/443fb4de8ebc375482a8277995782ec63ae26528
Cr-Commit-Position: refs/heads/master@{#32229}

Powered by Google App Engine
This is Rietveld 408576698