Chromium Code Reviews

Issue 1468253004: Adding src/third_party/chaijs (Javascript assertion library). (Closed)

Created:
5 years ago by dpapad
Modified:
5 years ago
Reviewers:
brettw
CC:
chromium-reviews, Dan Beam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding src/third_party/chaijs (Javascript assertion library). Committed: https://crrev.com/6e0c65e5834f4ca8b14cf29d327c14eb654d99e3 Cr-Commit-Position: refs/heads/master@{#362860}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+5900 lines, -0 lines)
A third_party/chaijs/LICENSE View 1 chunk +9 lines, -0 lines 0 comments
A third_party/chaijs/OWNERS View 1 chunk +2 lines, -0 lines 0 comments
A third_party/chaijs/README.chromium View 1 chunk +16 lines, -0 lines 0 comments
A third_party/chaijs/chai.js View 1 chunk +5873 lines, -0 lines 0 comments

Messages

Total messages: 15 (7 generated)
dpapad
@brettw Both security and open-source teams LGed. I think this is ready to go. Thank ...
5 years ago (2015-12-01 19:59:54 UTC) #4
dpapad
Friendly ping.
5 years ago (2015-12-02 21:42:13 UTC) #5
brettw
Whoops, sorry. LGTM
5 years ago (2015-12-02 21:45:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468253004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468253004/1
5 years ago (2015-12-02 22:11:09 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/143137)
5 years ago (2015-12-02 22:22:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468253004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468253004/1
5 years ago (2015-12-03 01:11:37 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 01:58:27 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-03 01:59:03 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e0c65e5834f4ca8b14cf29d327c14eb654d99e3
Cr-Commit-Position: refs/heads/master@{#362860}

Powered by Google App Engine