Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1468243002: update.py: Download platform-appropriate prebuilt clang (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

update.py: Download platform-appropriate prebuilt clang Also tweak the newline at the end of the stamp file to be compatible with update.sh. This way, if either downloads clang the other will consider it up-to-date. BUG=494442 NOTRY=true Committed: https://crrev.com/438f82d40aa397c2a7688c1b05228e3fb2e7560e Cr-Commit-Position: refs/heads/master@{#361236}

Patch Set 1 #

Patch Set 2 : remove testing goop #

Patch Set 3 : also remove obsolete todo #

Patch Set 4 : whoops did not mean to upload that patchset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M tools/clang/scripts/update.py View 1 3 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Nico
5 years ago (2015-11-23 21:46:16 UTC) #2
hans
lgtm
5 years ago (2015-11-23 21:50:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468243002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468243002/60001
5 years ago (2015-11-23 21:52:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133084)
5 years ago (2015-11-23 23:51:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468243002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468243002/60001
5 years ago (2015-11-24 01:19:07 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-11-24 02:32:28 UTC) #11
commit-bot: I haz the power
5 years ago (2015-11-24 02:33:01 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/438f82d40aa397c2a7688c1b05228e3fb2e7560e
Cr-Commit-Position: refs/heads/master@{#361236}

Powered by Google App Engine
This is Rietveld 408576698