Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1468233003: Add a warmup flag to visualbench (Closed)

Created:
5 years ago by Chris Dalton
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a warmup flag to visualbench Adds a flag to control whether we use a warmup bench. BUG=skia: Committed: https://skia.googlesource.com/skia/+/78f915e2f1281cec4a7885cd0211dcb7fa1ae486

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/VisualBench/VisualBenchmarkStream.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Chris Dalton
5 years ago (2015-11-24 17:36:32 UTC) #2
joshualitt
On 2015/11/24 17:36:32, Chris Dalton wrote: lgtm, but maybe want to add a note about ...
5 years ago (2015-11-24 21:52:02 UTC) #3
Chris Dalton
On 2015/11/24 21:52:02, joshualitt wrote: > On 2015/11/24 17:36:32, Chris Dalton wrote: > > lgtm, ...
5 years ago (2015-11-24 22:39:54 UTC) #4
Mark Kilgard
lgtm for me, the value of this is being able to profile a particular visualbench ...
5 years ago (2015-11-25 01:39:03 UTC) #6
Chris Dalton
Josh, is this comment ok?
5 years ago (2015-12-10 22:00:53 UTC) #7
joshualitt
On 2015/12/10 22:00:53, Chris Dalton wrote: > Josh, is this comment ok? lgtm
5 years ago (2015-12-10 22:03:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468233003/20001
5 years ago (2015-12-10 22:05:48 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-10 22:20:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/78f915e2f1281cec4a7885cd0211dcb7fa1ae486

Powered by Google App Engine
This is Rietveld 408576698