Issue 146823002: Use SkMScalar as intermediates in SkMatrix44::setConcat.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146823002: Use SkMScalar as intermediates in SkMatrix44::setConcat. (Closed)

Created:
6 years, 11 months ago by mtklein

Modified:
6 years, 11 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Use SkMScalar as intermediates in SkMatrix44::setConcat. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13167

Patch Set 1 #

Patch Set 2 : try without a flag #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/utils/SkMatrix44.cpp	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/146823002/30001

6 years, 11 months ago (2014-01-24 15:01:30 UTC) #3

mtklein

6 years, 11 months ago (2014-01-24 18:47:45 UTC) #5

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/147033002/ by mtklein@google.com.

The reason for reverting is: This will break many Chromium tests when we roll..

Expand Messages | Collapse Messages