Issue 1468183002: Strip trailing / or \ when rolling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1468183002: Strip trailing / or \ when rolling. (Closed)

Created:
5 years, 1 month ago by M-A Ruel

Modified:
5 years, 1 month ago

Reviewers:
Vadim Sh.

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

More Reviews

Description

Strip trailing / or \ when rolling. Otherwise it makes CL description like foo/bar// which is ugly. R=vadimsh@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297670

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	roll_dep.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 756223002 Patch 1

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468183002/1

5 years, 1 month ago (2015-11-23 19:05:36 UTC) #4

commit-bot: I haz the power

5 years, 1 month ago (2015-11-23 19:20:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297670

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages