Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: chromeos/dbus/debug_daemon_client.h

Issue 1468173003: [Tracing Clock Sync] Add TracingAgent interface in Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review fix Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/tracing_agent.cc ('k') | chromeos/dbus/debug_daemon_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/debug_daemon_client.h
diff --git a/chromeos/dbus/debug_daemon_client.h b/chromeos/dbus/debug_daemon_client.h
index 86427a2b287be86e7ec8d63ca64b5682a24ed0c3..a11d6ecf6b3884f211d1e9baeb9338223e173f67 100644
--- a/chromeos/dbus/debug_daemon_client.h
+++ b/chromeos/dbus/debug_daemon_client.h
@@ -11,6 +11,7 @@
#include "base/files/file.h"
#include "base/memory/ref_counted_memory.h"
#include "base/task_runner.h"
+#include "base/trace_event/tracing_agent.h"
#include "chromeos/chromeos_export.h"
#include "chromeos/dbus/dbus_client.h"
#include "third_party/cros_system_api/dbus/service_constants.h"
@@ -18,7 +19,9 @@
namespace chromeos {
// DebugDaemonClient is used to communicate with the debug daemon.
-class CHROMEOS_EXPORT DebugDaemonClient : public DBusClient {
+class CHROMEOS_EXPORT DebugDaemonClient
+ : public DBusClient,
+ public base::trace_event::TracingAgent {
public:
~DebugDaemonClient() override;
@@ -113,21 +116,11 @@ class CHROMEOS_EXPORT DebugDaemonClient : public DBusClient {
// Gets list of user log files that must be read by Chrome.
virtual void GetUserLogFiles(const GetLogsCallback& callback) = 0;
- // Requests to start system/kernel tracing.
- virtual void StartSystemTracing() = 0;
+ virtual void SetStopAgentTracingTaskRunner(
+ scoped_refptr<base::TaskRunner> task_runner) = 0;
- // Called once RequestStopSystemTracing() is complete. Takes one parameter:
- // - result: the data collected while tracing was active
- typedef base::Callback<void(const scoped_refptr<base::RefCountedString>&
- result)> StopSystemTracingCallback;
-
- // Requests to stop system tracing and calls |callback| when completed.
- virtual bool RequestStopSystemTracing(
- scoped_refptr<base::TaskRunner> task_runner,
- const StopSystemTracingCallback& callback) = 0;
-
- // Returns an empty SystemTracingCallback that does nothing.
- static StopSystemTracingCallback EmptyStopSystemTracingCallback();
+ // Returns an empty StopAgentTracingCallback that does nothing.
+ static StopAgentTracingCallback EmptyStopAgentTracingCallback();
// Called once TestICMP() is complete. Takes two parameters:
// - succeeded: information was obtained successfully.
« no previous file with comments | « base/trace_event/tracing_agent.cc ('k') | chromeos/dbus/debug_daemon_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698