[Tracing Clock Sync] Add TracingAgent interface in Chrome

content/browser/tracing/tracing_controller_impl_data_sinks.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "content/browser/tracing/tracing_controller_impl.h"
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/json/json_writer.h"
 #include "content/public/browser/browser_thread.h"
 #include "third_party/zlib/zlib.h"
@@ skipping 113 matching lines @@
 
     AddTraceChunkAndPassToEndpoint(trace_string);
   }
 
   void AddTraceChunkAndPassToEndpoint(const std::string& chunk) {
     trace_ += chunk;
 
     endpoint_->ReceiveTraceChunk(chunk);
   }
 
-  void SetSystemTrace(const std::string& data) override {
-    system_trace_ = data;
-  }
-
-  void SetPowerTrace(const std::string& data) override { power_trace_ = data; }
-
   void Close() override {
     AddTraceChunkAndPassToEndpoint("]");
-    if (!system_trace_.empty())
-      AddTraceChunkAndPassToEndpoint(",\"systemTraceEvents\": " +
-                                     system_trace_);
+
+    for (base::DictionaryValue::Iterator it(GetAdditionalTracingAgentTrace());
+         !it.IsAtEnd(); it.Advance()) {
+      std::string trace;
+      DCHECK(it.value().GetAsString(&trace));
+      if (it.key() == base::trace_event::TracingAgent::kCrOSTracingAgentName ||

[shatch, 2015/11/27 19:29:18]

Don't need to do this now but could probably go further in the future and not
have these if statements, just have the agent supply the key name.

[Zhen Wang, 2015/12/01 00:14:32]

Done.

+          it.key() == base::trace_event::TracingAgent::kETWTracingAgentName) {
+        AddTraceChunkAndPassToEndpoint(",\"systemTraceEvents\": " + trace);
+      } else if (it.key() ==
+                 base::trace_event::TracingAgent::kPowerTracingAgentName) {
+        AddTraceChunkAndPassToEndpoint(",\"powerTraceAsString\": " + trace);
+      }
+    }
+
     std::string metadataJSON;
     if (base::JSONWriter::Write(GetMetadata(), &metadataJSON) &&
         !metadataJSON.empty())
       AddTraceChunkAndPassToEndpoint(",\"metadata\": " + metadataJSON);
-    if (!power_trace_.empty()) {
-      AddTraceChunkAndPassToEndpoint(",\"powerTraceAsString\": " +
-                                     power_trace_);
-    }
 
     AddTraceChunkAndPassToEndpoint("}");
 
     scoped_ptr<const base::DictionaryValue> metadata(GetMetadata().DeepCopy());
     endpoint_->ReceiveTraceFinalContents(metadata.Pass(), trace_);
   }
 
  private:
   ~StringTraceDataSink() override {}
 
   scoped_refptr<TracingController::TraceDataEndpoint> endpoint_;
   std::string trace_;
-  std::string system_trace_;
-  std::string power_trace_;
 
   DISALLOW_COPY_AND_ASSIGN(StringTraceDataSink);
 };
 
 class CompressedStringTraceDataSink : public TracingController::TraceDataSink {
  public:
   explicit CompressedStringTraceDataSink(
       scoped_refptr<TracingController::TraceDataEndpoint> endpoint)
       : endpoint_(endpoint), already_tried_open_(false) {}
 
   void AddTraceChunk(const std::string& chunk) override {
     std::string tmp = chunk;
     scoped_refptr<base::RefCountedString> chunk_ptr =
         base::RefCountedString::TakeString(&tmp);
     BrowserThread::PostTask(
         BrowserThread::FILE, FROM_HERE,
         base::Bind(&CompressedStringTraceDataSink::AddTraceChunkOnFileThread,
                    this, chunk_ptr));
   }
 
-  void SetSystemTrace(const std::string& data) override {
-    system_trace_ = data;
-  }
-
-  void SetPowerTrace(const std::string& data) override { power_trace_ = data; }
-
   void Close() override {
     BrowserThread::PostTask(
         BrowserThread::FILE, FROM_HERE,
         base::Bind(&CompressedStringTraceDataSink::CloseOnFileThread, this));
   }
 
  private:
   ~CompressedStringTraceDataSink() override {}
 
   bool OpenZStreamOnFileThread() {
@@ skipping 63 matching lines @@
 
   void CloseOnFileThread() {
     DCHECK_CURRENTLY_ON(BrowserThread::FILE);
     if (!OpenZStreamOnFileThread())
       return;
 
     if (compressed_trace_data_.empty())
       AddTraceChunkAndCompressOnFileThread("{\"traceEvents\":[", false);
 
     AddTraceChunkAndCompressOnFileThread("]", false);
-    if (!system_trace_.empty()) {
-      AddTraceChunkAndCompressOnFileThread(
-          ",\"systemTraceEvents\": " + system_trace_, false);
+
+    for (base::DictionaryValue::Iterator it(GetAdditionalTracingAgentTrace());
+         !it.IsAtEnd(); it.Advance()) {
+      std::string trace;
+      DCHECK(it.value().GetAsString(&trace));
+      if (it.key() == base::trace_event::TracingAgent::kCrOSTracingAgentName ||
+          it.key() == base::trace_event::TracingAgent::kETWTracingAgentName) {
+        AddTraceChunkAndCompressOnFileThread(
+            ",\"systemTraceEvents\": " + trace, false);
+      } else if (it.key() ==
+                 base::trace_event::TracingAgent::kPowerTracingAgentName) {
+        AddTraceChunkAndCompressOnFileThread(
+            ",\"powerTraceAsString\": " + trace, false);
+      }
     }
+
     std::string metadataJSON;
     if (base::JSONWriter::Write(GetMetadata(), &metadataJSON) &&
         !metadataJSON.empty()) {
       AddTraceChunkAndCompressOnFileThread(",\"metadata\": " + metadataJSON,
                                            false);
     }
-    if (!power_trace_.empty()) {
-      AddTraceChunkAndCompressOnFileThread(
-          ",\"powerTraceAsString\": " + power_trace_, false);
-    }
     AddTraceChunkAndCompressOnFileThread("}", true);
 
     deflateEnd(stream_.get());
     stream_.reset();
 
     scoped_ptr<const base::DictionaryValue> metadata(GetMetadata().DeepCopy());
     endpoint_->ReceiveTraceFinalContents(metadata.Pass(),
                                          compressed_trace_data_);
   }
 
   scoped_refptr<TracingController::TraceDataEndpoint> endpoint_;
   scoped_ptr<z_stream> stream_;
   bool already_tried_open_;
   std::string compressed_trace_data_;
-  std::string system_trace_;
-  std::string power_trace_;
 
   DISALLOW_COPY_AND_ASSIGN(CompressedStringTraceDataSink);
 };
 
 }  // namespace
 
+void TracingController::TraceDataSink::AddAdditionalTracingAgentTrace(
+    const std::string& agent_name,
+    const std::string& trace_data) {
+  additional_tracing_agent_trace_.SetString(agent_name, trace_data);
+}
+
+const base::DictionaryValue&
+    TracingController::TraceDataSink::GetAdditionalTracingAgentTrace() const {
+  return additional_tracing_agent_trace_;
+}
+
 void TracingController::TraceDataSink::AddMetadata(
     const base::DictionaryValue& data) {
   metadata_.MergeDictionary(&data);
 }
 
 const base::DictionaryValue&
     TracingController::TraceDataSink::GetMetadata() const {
   return metadata_;
 }
 
@@ skipping 24 matching lines @@
   return new StringTraceDataEndpoint(callback);
 }
 
 scoped_refptr<TracingController::TraceDataEndpoint>
 TracingController::CreateFileEndpoint(const base::FilePath& file_path,
                                       const base::Closure& callback) {
   return new FileTraceDataEndpoint(file_path, callback);
 }
 
 }  // namespace content