Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1468163003: DevTools: Make tracking entry info on flame chart work with pan/zoom. (Closed)

Created:
5 years ago by alph
Modified:
5 years ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Make tracking entry info on flame chart work with pan/zoom. BUG=528489 Committed: https://crrev.com/0c3db54e48b8e3a569dad3b72bfc0d45517855fa Cr-Commit-Position: refs/heads/master@{#361354}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebaseline #

Patch Set 3 : more rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 1 2 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
alph
5 years ago (2015-11-23 22:50:33 UTC) #2
caseq
https://codereview.chromium.org/1468163003/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js (right): https://codereview.chromium.org/1468163003/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js#newcode709 third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js:709: _highlightEntry: function(show) let's just split this into _hideHighlight() and ...
5 years ago (2015-11-24 00:40:55 UTC) #3
caseq
lgtm
5 years ago (2015-11-24 02:44:52 UTC) #4
alph
https://codereview.chromium.org/1468163003/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js (right): https://codereview.chromium.org/1468163003/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js#newcode709 third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js:709: _highlightEntry: function(show) On 2015/11/24 00:40:55, caseq wrote: > let's ...
5 years ago (2015-11-24 02:44:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468163003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468163003/40001
5 years ago (2015-11-24 04:28:12 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133469)
5 years ago (2015-11-24 05:59:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468163003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468163003/40001
5 years ago (2015-11-24 15:42:18 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-24 16:24:00 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/0c3db54e48b8e3a569dad3b72bfc0d45517855fa Cr-Commit-Position: refs/heads/master@{#361354}
5 years ago (2015-11-24 16:25:03 UTC) #13
alph
5 years ago (2015-11-26 00:22:05 UTC) #14
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1479723002/ by alph@chromium.org.

The reason for reverting is: Broke item selection on flamechart..

Powered by Google App Engine
This is Rietveld 408576698