Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1468163002: [CacheStorage] Use a map of scoped_ptrs instead of raw pointers (Closed)

Created:
5 years, 1 month ago by jkarlin
Modified:
5 years ago
Reviewers:
nhiroki
CC:
chromium-reviews, darin-cc_chromium.org, jam, jkarlin+watch_chromium.org, nhiroki
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CacheStorage] Use a map of scoped_ptrs instead of raw pointers Committed: https://crrev.com/952f3b51d5cb07c394ebfc1181f7e37531400e09 Cr-Commit-Position: refs/heads/master@{#361324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M content/browser/cache_storage/cache_storage_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/cache_storage/cache_storage_manager.cc View 3 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jkarlin
nhiroki@: PTAL, thank you!
5 years, 1 month ago (2015-11-23 18:41:22 UTC) #2
nhiroki
LGTM!
5 years, 1 month ago (2015-11-24 01:01:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468163002/1
5 years ago (2015-11-24 11:43:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 12:17:55 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-24 12:19:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/952f3b51d5cb07c394ebfc1181f7e37531400e09
Cr-Commit-Position: refs/heads/master@{#361324}

Powered by Google App Engine
This is Rietveld 408576698