Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1468103002: Add context information to BidiResolver.isolatedRuns() (Closed)

Created:
5 years, 1 month ago by kojii
Modified:
5 years, 1 month ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, leviw+bidiwatch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add context information to BidiResolver.isolatedRuns() This patch is a port of http://wkb.ug/149153, which is a port of a fix for crbug.com/520282. The WebKit patch has additional changes to carry more information of isolated runs along with BidiRun. As we find we need to carry more context with isolated runs in crbug.com/391260, this change is useful. BUG=520282 Committed: https://crrev.com/f5c7aca8e2c3f4ae965f3c6098e4c6eb00366b30 Cr-Commit-Position: refs/heads/master@{#361258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -96 lines) Patch
M third_party/WebKit/Source/core/layout/BidiRunForLine.cpp View 5 chunks +13 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineIterator.h View 10 chunks +35 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/TrailingObjects.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/BidiResolver.h View 17 chunks +40 lines, -38 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
kojii
PTAL.
5 years, 1 month ago (2015-11-23 18:27:06 UTC) #4
kojii
PTAL.
5 years, 1 month ago (2015-11-23 18:27:10 UTC) #5
leviw_travelin_and_unemployed
Seems safer, as well. LGTM.
5 years, 1 month ago (2015-11-23 19:44:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468103002/1
5 years, 1 month ago (2015-11-24 00:55:05 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133293)
5 years, 1 month ago (2015-11-24 03:29:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468103002/1
5 years, 1 month ago (2015-11-24 05:14:25 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-24 05:21:04 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 05:22:04 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5c7aca8e2c3f4ae965f3c6098e4c6eb00366b30
Cr-Commit-Position: refs/heads/master@{#361258}

Powered by Google App Engine
This is Rietveld 408576698