Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: sdk/lib/_internal/pub/test/lock_file_test.dart

Issue 14681002: Sort pubspec.lock packages. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Removed print statement. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/lock_file.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/test/lock_file_test.dart
diff --git a/sdk/lib/_internal/pub/test/lock_file_test.dart b/sdk/lib/_internal/pub/test/lock_file_test.dart
index 95fcd71fd0b99dc3b82b0ffb1c0552e565b9a8dd..0f7fe53875149a9ec29380ea88bb1e654c9ee19b 100644
--- a/sdk/lib/_internal/pub/test/lock_file_test.dart
+++ b/sdk/lib/_internal/pub/test/lock_file_test.dart
@@ -159,12 +159,16 @@ packages:
});
group('serialize()', () {
+ var lockfile;
+ setUp(() {
+ lockfile = new LockFile.empty();
+ });
+
test('dumps the lockfile to YAML', () {
- var lockfile = new LockFile.empty();
lockfile.packages['foo'] = new PackageId(
'foo', mockSource, new Version.parse('1.2.3'), 'foo desc');
lockfile.packages['bar'] = new PackageId(
- 'foo', mockSource, new Version.parse('3.2.1'), 'bar desc');
+ 'bar', mockSource, new Version.parse('3.2.1'), 'bar desc');
expect(loadYaml(lockfile.serialize()), equals({
'packages': {
@@ -181,6 +185,29 @@ packages:
}
}));
});
+
+ test('lockfile is alphabetized by package name', () {
+ var testNames = ['baz', 'Qwe', 'Q', 'B', 'Bar', 'bar', 'foo'];
+ testNames.forEach((name) {
+ lockfile.packages[name] = new PackageId(name, mockSource,
+ new Version.parse('5.5.5'), '$name desc');
+ });
+
+ expect(lockfile.serialize(),
+ '# Generated by pub\n'
+ '# See http://pub.dartlang.org/doc/glossary.html#lockfile\n'
+ '\n'
+ '{"packages":{'
+ '"B":{"version":"5.5.5","source":"mock","description":"B desc"},'
+ '"Bar":{"version":"5.5.5","source":"mock","description":"Bar desc"},'
+ '"Q":{"version":"5.5.5","source":"mock","description":"Q desc"},'
+ '"Qwe":{"version":"5.5.5","source":"mock","description":"Qwe desc"},'
+ '"bar":{"version":"5.5.5","source":"mock","description":"bar desc"},'
+ '"baz":{"version":"5.5.5","source":"mock","description":"baz desc"},'
+ '"foo":{"version":"5.5.5","source":"mock","description":"foo desc"}}}'
+ '\n'
+ );
+ });
});
});
}
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/lock_file.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698