Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1468093004: Work-around for passing CC/CXX for arm cross-compilation with make. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
Reviewers:
martyn.capewell
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Work-around for passing CC/CXX for arm cross-compilation with make. BUG=chromium:534332 LOG=n Committed: https://crrev.com/f54a0559012464bf37489662ee2cc03c9b2a1eba Cr-Commit-Position: refs/heads/master@{#32214}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/standalone.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael Achenbach
PTAL
5 years ago (2015-11-24 13:51:24 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468093004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468093004/1
5 years ago (2015-11-24 13:52:15 UTC) #5
martyn.capewell
lgtm Works for me.
5 years ago (2015-11-24 14:09:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468093004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468093004/1
5 years ago (2015-11-24 14:15:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 14:33:51 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-24 14:34:12 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f54a0559012464bf37489662ee2cc03c9b2a1eba
Cr-Commit-Position: refs/heads/master@{#32214}

Powered by Google App Engine
This is Rietveld 408576698