Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1468073002: Revert of Switch Skia's libjpeg-turbo to 1.4.2 (Closed)

Created:
5 years, 1 month ago by msarett
Modified:
5 years, 1 month ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Switch Skia's libjpeg-turbo to 1.4.2 (patchset #2 id:160001 of https://codereview.chromium.org/1469553002/ ) Reason for revert: Breaking jpeg decodes everywhere. I need to look into this. Original issue's description: > Switch Skia's libjpeg-turbo to 1.4.2 > > The Android security team wants Android to be on the latest version > of libjpeg-turbo, so Skia should test on this version as well. > > This shouldn't affect Gold. > > I wouldn't be surprised if this causes a few ASAN/valgrind issues > that we need to fix. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/8e8eda9d4d2e6e65e3339eaaaf8144a4ef6c721c TBR=scroggo@google.com,djsollen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/4b9596109a32ec61ef9ffbbf03684e9f99c3cbf7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -52 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gyp/libjpeg-turbo.gyp View 9 chunks +56 lines, -51 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
msarett
Created Revert of Switch Skia's libjpeg-turbo to 1.4.2
5 years, 1 month ago (2015-11-23 15:25:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468073002/1
5 years, 1 month ago (2015-11-23 15:25:43 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 15:25:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4b9596109a32ec61ef9ffbbf03684e9f99c3cbf7

Powered by Google App Engine
This is Rietveld 408576698