Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1468063002: Remove ScopedVector from video_capture_buffer_pool (Closed)

Created:
5 years ago by mkollaro
Modified:
5 years ago
Reviewers:
mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from video_capture_buffer_pool Usage of std::vector for movable types has been recently whitelisted. https://chromium-cpp.appspot.com/#library-whitelist BUG=554289 Committed: https://crrev.com/d028241e02bb51482e151797900d427035dc607b Cr-Commit-Position: refs/heads/master@{#361290}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/browser/renderer_host/media/video_capture_buffer_pool.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
mkollaro
5 years ago (2015-11-23 15:24:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468063002/20001
5 years ago (2015-11-23 16:45:13 UTC) #4
mcasas
LGTM if all bots pass, thanks! Can you add to the description that std::vector<> of ...
5 years ago (2015-11-23 17:46:52 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-23 19:38:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468063002/20001
5 years ago (2015-11-24 08:35:55 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-24 08:41:08 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-24 08:42:00 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d028241e02bb51482e151797900d427035dc607b
Cr-Commit-Position: refs/heads/master@{#361290}

Powered by Google App Engine
This is Rietveld 408576698