Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1468053004: Add /auth/api/v1/server/info endpoints. (Closed)

Created:
5 years, 1 month ago by Vadim Sh.
Modified:
5 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Add /auth/api/v1/server/info endpoints. Serve it and fetch it. For interoperability with luci-py components.auth. Will be used by luci-cron when configuring PubSub topic to pass to Swarming. R=maruel@chromium.org BUG= Committed: https://github.com/luci/luci-go/commit/d7afe013e8d7c0ab5b8fdeebc7f537ef6f9b6e9a

Patch Set 1 : add-auth-info-call #

Patch Set 2 : fix typo #

Total comments: 5

Patch Set 3 : add runtime version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -0 lines) Patch
M appengine/gaeauth/server/default.go View 1 2 3 chunks +19 lines, -0 lines 0 comments Download
A server/auth/info/info.go View 1 2 1 chunk +77 lines, -0 lines 0 comments Download
A server/auth/info/info_test.go View 1 2 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Vadim Sh.
e.g. https://luci-cron.appspot.com/auth/api/v1/server/info also compare to https://chromium-swarm.appspot.com/auth/api/v1/server/info
5 years, 1 month ago (2015-11-24 03:31:28 UTC) #1
M-A Ruel
https://codereview.chromium.org/1468053004/diff/20001/appengine/gaeauth/server/default.go File appengine/gaeauth/server/default.go (right): https://codereview.chromium.org/1468053004/diff/20001/appengine/gaeauth/server/default.go#newcode63 appengine/gaeauth/server/default.go:63: AppRuntime: "go", Do you think it's useful to have ...
5 years ago (2015-11-24 13:48:00 UTC) #3
Vadim Sh.
https://codereview.chromium.org/1468053004/diff/20001/appengine/gaeauth/server/default.go File appengine/gaeauth/server/default.go (right): https://codereview.chromium.org/1468053004/diff/20001/appengine/gaeauth/server/default.go#newcode63 appengine/gaeauth/server/default.go:63: AppRuntime: "go", On 2015/11/24 13:47:59, M-A Ruel wrote: > ...
5 years ago (2015-11-24 19:27:29 UTC) #4
M-A Ruel
https://codereview.chromium.org/1468053004/diff/20001/server/auth/info/info.go File server/auth/info/info.go (right): https://codereview.chromium.org/1468053004/diff/20001/server/auth/info/info.go#newcode34 server/auth/info/info.go:34: // FetchServiceInfo fetches information about the service at given ...
5 years ago (2015-11-24 19:31:34 UTC) #5
Vadim Sh.
On 2015/11/24 19:31:34, M-A Ruel wrote: > https://codereview.chromium.org/1468053004/diff/20001/server/auth/info/info.go > File server/auth/info/info.go (right): > > https://codereview.chromium.org/1468053004/diff/20001/server/auth/info/info.go#newcode34 ...
5 years ago (2015-11-24 19:35:02 UTC) #6
M-A Ruel
lgtm
5 years ago (2015-11-24 19:42:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468053004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468053004/40001
5 years ago (2015-11-24 19:42:47 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-24 19:45:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/d7afe013e8d7c0ab5b8fdeebc7f537ef6f9b6e9a

Powered by Google App Engine
This is Rietveld 408576698