Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1468033002: Remove unused memory functions (Closed)

Created:
5 years, 1 month ago by Ruud van Asseldonk
Modified:
5 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, blink-reviews, dglazkov+blink, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, blink-reviews-api_chromium.org, primiano CORP (USE chromium), jamesr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused memory functions In |blink::Platform|, the functions |processMemorySizesInBytes| and |memoryAllocatorWasteInBytes| are unused. Let's remove them. The function |base::allocator::GetAllocatorWasteSize| is not used anywhere except in the unused Blink functions, so it can be removed as well. Detailed information about memory allocators is available in the memory- infra category of chrome://tracing. It supports all allocators, not just tcmalloc. |GetAllocatorWasteSize| was implemented for tcmalloc only. Committed: https://crrev.com/8e7faebfbdee8e62471a7ee839279f184b68980a Cr-Commit-Position: refs/heads/master@{#361303}

Patch Set 1 #

Patch Set 2 : Remove unused functions from base/allocator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -121 lines) Patch
M base/allocator/allocator_extension.h View 1 2 chunks +0 lines, -11 lines 0 comments Download
M base/allocator/allocator_extension.cc View 1 2 chunks +0 lines, -14 lines 0 comments Download
M base/allocator/allocator_extension_thunks.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M base/allocator/allocator_extension_thunks.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M content/app/content_main_runner.cc View 1 2 chunks +0 lines, -17 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M content/child/blink_platform_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/blink_platform_impl.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M content/common/render_process_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Ruud van Asseldonk
brettw, wfh, can you please take a look at this cleanup CL?
5 years, 1 month ago (2015-11-23 13:17:29 UTC) #3
brettw
lgtm
5 years, 1 month ago (2015-11-23 19:22:55 UTC) #4
Will Harris
base/allocator lgtm
5 years, 1 month ago (2015-11-23 21:35:06 UTC) #5
Primiano Tucci (use gerrit)
lgtm
5 years, 1 month ago (2015-11-24 10:11:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468033002/20001
5 years, 1 month ago (2015-11-24 10:12:31 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-24 10:19:45 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 10:20:24 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e7faebfbdee8e62471a7ee839279f184b68980a
Cr-Commit-Position: refs/heads/master@{#361303}

Powered by Google App Engine
This is Rietveld 408576698