Add checking for license formats to third_party/PRESUBMIT

android_webview/tools/webview_licenses.py

 #!/usr/bin/python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Checks third-party licenses for the purposes of the Android WebView build.
 
 The Android tree includes a snapshot of Chromium in order to power the system
 WebView.  This tool checks that all code uses open-source licenses compatible
 with Android, and that we meet the requirements of those licenses. It can also
 be used to generate an Android NOTICE file for the third-party code.
 
 It makes use of src/tools/licenses.py and the README.chromium files on which
 it depends. It also makes use of a data file, third_party_files_whitelist.txt,
 which whitelists indicidual files which contain third-party code but which
 aren't in a third-party directory with a README.chromium file.
 """
 
+import imp
 import optparse
 import os
 import re
 import subprocess
 import sys
 import textwrap
 
 
 REPOSITORY_ROOT = os.path.abspath(os.path.join(
     os.path.dirname(__file__), '..', '..'))
 
+# Import third_party/PRESUBMIT.py via imp to avoid importing a random
+# PRESUBMIT.py from $PATH, also make sure we don't generate a .pyc file.
+sys.dont_write_bytecode = True
+third_party = \
+  imp.load_source('PRESUBMIT', \
+                  os.path.join(REPOSITORY_ROOT, 'third_party', 'PRESUBMIT.py'))
+
 sys.path.append(os.path.join(REPOSITORY_ROOT, 'tools'))
 import licenses
 
 import known_issues
 
+class InputApi(object):
+  def __init__(self):
+    self.re = re

[mkosiba (inactive), 2014/01/31 17:47:38]

could you explain why this is needed? PRESUBMIT.py already imports re so I'd
expect it would "just work"..

[mnaganov (inactive), 2014/02/03 10:00:26]

No -- in fact, PRESUBMIT scripts don't import anything in a "classic" way.
Instead, they get all the packages via 'input_api' and 'output_api' objects
passed to their functions. See
https://code.google.com/p/chromium/codesearch#chromium/tools/depot_tools/pres...

[mkosiba (inactive), 2014/02/03 10:30:55]

ah, thanks for that. I got confused by the import statements at the beginning of
the file.

+
 def GetIncompatibleDirectories():
   """Gets a list of third-party directories which use licenses incompatible
   with Android. This is used by the snapshot tool and the AOSP bot.
   Returns:
     A list of directories.
   """
 
-  whitelist = [
-    'Apache( Version)? 2(\.0)?',
-    '(New )?([23]-Clause )?BSD( [23]-Clause)?( with advertising clause)?',
-    'L?GPL ?v?2(\.[01])?( or later)?',
-    'MIT(/X11)?(-like)?',
-    'MPL 1\.1 ?/ ?GPL 2(\.0)? ?/ ?LGPL 2\.1',
-    'MPL 2(\.0)?',
-    'Microsoft Limited Public License',
-    'Microsoft Permissive License',
-    'Public Domain',
-    'Python',
-    'SGI Free Software License B',
-    'University of Illinois\/NCSA Open Source',
-    'X11',
-  ]
-  regex = '^(%s)$' % '|'.join(whitelist)
   result = []
   for directory in _FindThirdPartyDirs():
     if directory in known_issues.KNOWN_ISSUES:
       result.append(directory)
       continue
     try:
       metadata = licenses.ParseDir(directory, REPOSITORY_ROOT,
                                    require_license_file=False)
     except licenses.LicenseError as e:
       print 'Got LicenseError while scanning ' + directory
       raise
     if metadata.get('License Android Compatible', 'no').upper() == 'YES':
       continue
     license = re.split(' [Ll]icenses?$', metadata['License'])[0]
-    tokens = [x.strip() for x in re.split(' and |,', license) if len(x) > 0]
-    for token in tokens:
-      if not re.match(regex, token, re.IGNORECASE):
-        result.append(directory)
-        break
+    if not third_party.LicenseIsCompatibleWithAndroid(InputApi(), license):
+      result.append(directory)
   return result
 
 class ScanResult(object):
   Ok, Warnings, Errors = range(3)
 
 def _CheckLicenseHeaders(excluded_dirs_list, whitelisted_files):
   """Checks that all files which are not in a listed third-party directory,
   and which do not use the standard Chromium license, are whitelisted.
   Args:
     excluded_dirs_list: The list of directories to exclude from scanning.
@@ skipping 219 matching lines @@
       print ("Incompatibly licensed directories found:" +
              "\n".join(incompatible_directories))
       return ScanResult.Errors
     return ScanResult.Ok
 
   parser.print_help()
   return ScanResult.Errors
 
 if __name__ == '__main__':
   sys.exit(main())