third_party/WebKit/Source/modules/imagebitmap/WindowImageBitmapFactories.cpp - Issue 1468023002: Rename imageSizeForLayoutObject() to imageSize()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/imagebitmap/WindowImageBitmapFactories.cpp

Issue 1468023002: Rename imageSizeForLayoutObject() to imageSize() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make LayoutObject::shouldRespectImageOrientation class static and make use of it Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/imagebitmap/WindowImageBitmapFactories.cpp

diff --git a/third_party/WebKit/Source/modules/imagebitmap/WindowImageBitmapFactories.cpp b/third_party/WebKit/Source/modules/imagebitmap/WindowImageBitmapFactories.cpp

index 2d02ab5c44381840a71e2e00d80e144cb0477180..7fdf95e08e1ee5067bfd4ba32a2286d50209e498 100644

--- a/third_party/WebKit/Source/modules/imagebitmap/WindowImageBitmapFactories.cpp

+++ b/third_party/WebKit/Source/modules/imagebitmap/WindowImageBitmapFactories.cpp

@@ -42,6 +42,7 @@

#include "core/html/HTMLImageElement.h"

#include "core/html/HTMLVideoElement.h"

#include "core/html/ImageData.h"

+#include "core/layout/LayoutObject.h"

#include "core/workers/WorkerGlobalScope.h"

#include "modules/canvas2d/CanvasRenderingContext2D.h"

#include "platform/SharedBuffer.h"

@@ -54,8 +55,10 @@ namespace blink {

static LayoutSize sizeFor(HTMLImageElement* image)

{

- if (ImageResource* cachedImage = image->cachedImage())

- return cachedImage->imageSizeForLayoutObject(image->layoutObject(), 1.0f); // FIXME: Not sure about this.

+ if (ImageResource* cachedImage = image->cachedImage()) {

+ LayoutObject* layoutObject = image->layoutObject();

Yoav Weiss 2015/11/24 14:59:05 I think the extra variable is not really needed

+ return cachedImage->imageSize(LayoutObject::shouldRespectImageOrientation(layoutObject), 1.0f); // FIXME: Not sure about this.

+ }

return LayoutSize();

}

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | no next file » | no next file with comments »