Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.cc

Issue 1468013002: ScopedPtrMap -> std::map from /component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/browser/metrics_web_contents_observer.cc
diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.cc b/components/page_load_metrics/browser/metrics_web_contents_observer.cc
index c112a7141646455f8da79402c6fdd9cd2bd1b8ec..da77b1b5253afaeb7d6af3ba98d94dd11078b178 100644
--- a/components/page_load_metrics/browser/metrics_web_contents_observer.cc
+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.cc
@@ -410,10 +410,10 @@ void MetricsWebContentsObserver::DidStartNavigation(
// Passing raw pointers to observers_ and embedder_interface_ is safe because
// the MetricsWebContentsObserver owns them both list and they are torn down
// after the PageLoadTracker.
- provisional_loads_.insert(navigation_handle,
- make_scoped_ptr(new PageLoadTracker(
- in_foreground_, embedder_interface_.get(),
- navigation_handle, &observers_)));
+ provisional_loads_.insert(std::make_pair(
+ navigation_handle, make_scoped_ptr(new PageLoadTracker(
+ in_foreground_, embedder_interface_.get(),
+ navigation_handle, &observers_))));
}
void MetricsWebContentsObserver::DidFinishNavigation(
@@ -422,7 +422,9 @@ void MetricsWebContentsObserver::DidFinishNavigation(
return;
scoped_ptr<PageLoadTracker> finished_nav(
- provisional_loads_.take_and_erase(navigation_handle));
+ std::move(provisional_loads_[navigation_handle]));
+ provisional_loads_.erase(navigation_handle);
+
// There's a chance a navigation could have started before we were added to a
// tab. Bail out early if this is the case.
if (!finished_nav)
« no previous file with comments | « components/page_load_metrics/browser/metrics_web_contents_observer.h ('k') | components/policy/core/common/schema.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698