test/cctest/interpreter/test-bytecode-generator.cc - Issue 1468003002: [Interpreter] Add support for cast operators to bytecode graph builder and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1468003002: [Interpreter] Add support for cast operators to bytecode graph builder and (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed review comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/cctest/compiler/test-run-bytecode-graph-builder.cc ('k') | test/unittests/compiler/bytecode-graph-builder-unittest.cc » ('j') | test/unittests/compiler/node-test-utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/test-bytecode-generator.cc

diff --git a/test/cctest/interpreter/test-bytecode-generator.cc b/test/cctest/interpreter/test-bytecode-generator.cc

index 4177e07dc28697ef27aff8b72e260384f69828e2..de5ba8c99ab99f2ccac52cfefb87983b8d941af8 100644

--- a/test/cctest/interpreter/test-bytecode-generator.cc

+++ b/test/cctest/interpreter/test-bytecode-generator.cc

@@ -3339,7 +3339,7 @@ TEST(ObjectLiterals) {

{"var n = 'name'; return { [n]: 'val', get a() { }, set a(b) {} };",

5 * kPointerSize,

- 69,

+ 67,

{

B(LdaConstant), U8(0), //

B(Star), R(0), //

@@ -3356,7 +3356,6 @@ TEST(ObjectLiterals) {

B(CallRuntime), U16(Runtime::kDefineDataPropertyUnchecked), R(1), //

U8(4), //

B(LdaConstant), U8(3), //

- B(ToName), //

B(Star), R(2), //

B(LdaConstant), U8(4), //

B(CreateClosure), U8(0), //

@@ -3366,7 +3365,6 @@ TEST(ObjectLiterals) {

B(CallRuntime), U16(Runtime::kDefineGetterPropertyUnchecked), //

R(1), U8(4), //

B(LdaConstant), U8(3), //

- B(ToName), //

B(Star), R(2), //

B(LdaConstant), U8(5), //

B(CreateClosure), U8(0), //