Clean up ifdef around FilePath creation(webkit)

webkit/plugins/npapi/plugin_stream.cc

Index: webkit/plugins/npapi/plugin_stream.cc
diff --git a/webkit/plugins/npapi/plugin_stream.cc b/webkit/plugins/npapi/plugin_stream.cc
index 1769b68609573b7c608fb2a0b9c50abd1cecbc20..44fc2247b4e4683dc1bacaf7d22d6a66503a4c29 100644
--- a/webkit/plugins/npapi/plugin_stream.cc
+++ b/webkit/plugins/npapi/plugin_stream.cc
@@ -83,11 +83,7 @@ bool PluginStream::Open(const std::string& mime_type,
   } else {
     GURL gurl(stream_.url);
 
-#if defined(OS_WIN)
-    base::FilePath path(UTF8ToWide(gurl.path()));
-#elif defined(OS_POSIX)
-    base::FilePath path(gurl.path());
-#endif
+    base::FilePath path = base::FilePath::FromUTF8Unsafe(gurl.path());
     if (net::GetMimeTypeFromFile(path, &temp_mime_type))

[Bernhard Bauer, 2013/05/16 06:48:05]

I think MimeUtil::GetMimeTypeFromExtensionHelper() should also be updated,
otherwise we have a SysWideToNativeMB conversion here on Windows that we don't
undo.

[mrunal, 2013/05/17 00:16:00]

I don't think it will call SysWideToNativeMB for Windows since there is a
different version of FromUTF8Unsafe() (file_path.cc:line 622) for Windows which
would get called here.

[Bernhard Bauer, 2013/05/17 07:04:44]

Oh, right! But what about Linux then?

Basically, MimeUtil uses the same #ifdef that we have here, just with a
FilePath::StringType instead of a FilePath (and in reverse), so if this is the
right thing to do here and we want to get the same string back, we should also
change that.

[mrunal, 2013/05/20 23:48:06]

Specifically what do you want me to change? Are you suggesting I change
MimeUtil::GetMimeTypeFromExtensionHelper() by substituting
WideToUTF8(SysNativeMBToWide(ext)) for OS_POSIX?
I'm not sure if that's the right thing to do as not all the functions calling
GetMimeTypeFromFile() are/will be calling FromUTF8Unsafe(). As per the bug
description it sounded this change won't be any worse than the current #ifdef

[Bernhard Bauer, 2013/05/21 17:31:01]

No, only for defined(OS_POSIX) && !(defined(OS_MACOSX) || defined(OS_CHROMEOS)),
just like FilePath::AsUTF8Unsafe does. In fact, it might be the right thing to
just use FilePath::AsUTF8Unsafe instead (as you can see, this is very subtle to
get right).
Well, all the functions that construct a FilePath from a UTF8 string are (or at
least they should be, and that's what you're changing here).
Yes, that's why I'm asking you to make the change in more places. Basically,
we're making the assumption that on Linux, file paths are in the native
encoding. That assumption isn't always correct, but if we make it, we should
make it everywhere in the code instead of just in some places.

In particular, if we use the same reversible mapping from FilePath to UTF8
string everywhere, in places like here it doesn't make a difference whether our
assumption that all file paths are native encoding is correct, because we'll get
back the same string in any case!

[mrunal, 2013/05/22 01:55:39]

Hi Bernhard,
Thanks for the clarification. I will update the
MimeUtil::GetMimeTypeFromExtensionHelper() with your suggested changes.

       char_mime_type = temp_mime_type.c_str();
   }