Clean up ifdef around FilePath creation(webkit)

net/base/mime_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <iterator>
 #include <map>
 #include <string>
 
 #include "net/base/mime_util.h"
 #include "net/base/platform_mime_util.h"
 
 #include "base/hash_tables.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/strings/string_split.h"
+#include "base/strings/sys_string_conversions.h"
 #include "base/utf_string_conversions.h"
 
 using std::string;
 
 namespace {
 
 struct MediaType {
   const char name[12];
   const char matcher[13];
 };
@@ skipping 186 matching lines @@
     return false;
 
   // We implement the same algorithm as Mozilla for mapping a file extension to
   // a mime type.  That is, we first check a hard-coded list (that cannot be
   // overridden), and then if not found there, we defer to the system registry.
   // Finally, we scan a secondary hard-coded list to catch types that we can
   // deduce but that we also want to allow the OS to override.
 
 #if defined(OS_WIN)
   string ext_narrow_str = WideToUTF8(ext);
-#elif defined(OS_POSIX)
+#elif defined(OS_MACOSX) || defined(OS_CHROMEOS)
   const string& ext_narrow_str = ext;
+#else
+  const string& ext_narrow_str = WideToUTF8(base::SysNativeMBToWide(ext));

[Bernhard Bauer, 2013/05/28 21:26:14]

Why don't you just use FilePath::AsUTF8Unsafe? There is really no need to have
this piece of logic in multiple places, particularly if it's as subtle as this.

[mrunal, 2013/05/28 21:38:47]

Because FilePath::AsUTF8Unsafe() is not a static function like FromUTF8Unsafe().
It's a member function. We are dealing with base::FilePath::StringType here.

[Bernhard Bauer, 2013/05/28 22:04:00]

Right, just construct a new FilePath (which copies the string), then call
AsUTF8Unsafe(). Having to go through a FilePath object here is somewhat
unfortunate, but then so is having to call an ...Unsafe() method in the first
place.

[mrunal, 2013/05/28 22:41:02]

Yeah that will be bit ugly but I get your point now. I will upload another
patch.

 #endif
   const char* mime_type;
 
   mime_type = FindMimeType(primary_mappings, arraysize(primary_mappings),
                            ext_narrow_str.c_str());
   if (mime_type) {
     *result = mime_type;
     return true;
   }
 
@@ skipping 745 matching lines @@
   return CERTIFICATE_MIME_TYPE_UNKNOWN;
 }
 
 bool IsSupportedCertificateMimeType(const std::string& mime_type) {
   CertificateMimeType file_type =
       GetCertificateMimeTypeForMimeType(mime_type);
   return file_type != CERTIFICATE_MIME_TYPE_UNKNOWN;
 }
 
 }  // namespace net